Installation in the /usr/lib64 instead of /usr/lib on 64-bit systems with LSB

[Peter Kovář]

Destination directory for installation of the x265 libraries on 64-bit systems following Linux Standard Base specification should be ${CMAKE_INSTALL_PREFIX}/lib64 instead of ${CMAKE_INSTALL_PREFIX}/lib

Attached is the patch to cmake_install.cmake

[djcj]

I think you actually have to fix that in one of the *.cmake.in or CMakeLists.txt files, because afaik the cmake files are generated from those. I had pointed that out in Issue #37 too. I think a libprefix option that can be set with the cmake configuration, like you can already do with the standard prefix, would be optimal.

BTW I'm pretty sure the destination folder should be {prefix}/lib/{x86_64|i386}-linux-gnu. At least on Ubuntu that's the destination of many libs. I don't even have /usr/lib64 on my system.

[Peter Kovář]

I agree that --libdir option would be needed.

/usr/lib64 is destination of libraries on LSB 64-bit systems such as Red Hat, Fedora, OpenSUSE etc.

[Steve Borho]

cmake_install is machine generated, so the patch doesn't help much, but this is a relatively simple issue.

I can add -DINSTALL_LIBDIR=lib/x86_64-linux-gnu

Would you need to specify the bin folder as well?

[Peter Kovář]

With the patch file I wanted to indicate what's needed to be modified.

lib/x86_64-linux-gnu is installation directory on Ubuntu. I was thinking about automatic path generation derived from CMAKE_INSTALL_PREFIX and ABI

On LSB systems it should be as follows:

Install the project... -- Install configuration: "RelWithDebInfo" -- Installing: /usr/lib64/libx265.a -- Installing: /usr/include/x265.h -- Installing: /usr/include/x265_config.h -- Installing: /usr/lib64/libx265.so.0.8 -- Up-to-date: /usr/lib64/libx265.so.9 -- Up-to-date: /usr/lib64/libx265.so -- Installing: /usr/lib64/pkgconfig/x265.pc -- Installing: /usr/bin/x265

[Steve Borho]

cmake: make lib and bin install folders user configurable (closes #40)

→ <<cset a02a4ba9629e>>

[Peter Kovář]

Almost perfect. But pkgconfig was missing. Attaching the patch.

[Steve Borho]

cmake: pkgconfig file must be installed in user-specified lib folder (refs #40)

→ <<cset ab9c23ebb527>>

[djcj]

source/x265.pc.in still has to be fixed: https://bitbucket.org/multicoreware/x265/pull-request/8/x265pcin-edited-online-with-bitbucket/diff

[Steve Borho]

nice catch, will patch today

[Steve Borho]

pkgconfig: allow user-supplied lib folder (closes #40)

→ <<cset 8830c8bf15cb>>