X265 failed when build with permissive- + MSVC on windows

[Former user]

Build X265 with permissive- by msvc failed with error C2362, this issue can be reproduced from master revision 288ab83. Could you please help take a look at this? Noted that this issue only found when compiles with unreleased vctoolset, that next release of MSVC will have this behavior.

Repro:

1. git clone https://github.com/videolan/x265 D:\X265\src
2. Open a VS 2017 x86 command prompt and browse to D:\X265
3. set CL=/permissive-
4. mkdir build_x86 && pushd build_x86
5. cmake -G "Visual Studio 15 2017" -DCMAKE_SYSTEM_VERSION=10.0.17134.0 ..\src\source
6. mkdir build_x86_ltcg && pushd build_x86_ltcg
7. cmake -G "Visual Studio 15 2017" -DCMAKE_SYSTEM_VERSION=10.0.17134.0 -DCMAKE_EXE_LINKER_FLAGS="/LTCG" -DCMAKE_C_FLAGS="/GL" -DCMAKE_CXX_FLAGS="/GL" ..\src\source
8. msbuild /p:Configuration=Release;Platform=Win32 build_x86\x265.sln /t:Rebuild /m /p:BuildInParallel=true

Failures:

d:\x265\src\source\encoder\api.cpp(491): error C2362: initialization of 'interData' is skipped by 'goto fail'

d:\x265\src\source\encoder\api.cpp(454): note: see declaration of 'interData'

d:\x265\src\source\encoder\api.cpp(491): note: see declaration of 'fail'

d:\x265\src\source\encoder\api.cpp(491): error C2362: initialization of 'intraData' is skipped by 'goto fail'

d:\x265\src\source\encoder\api.cpp(445): note: see declaration of 'intraData'

d:\x265\src\source\encoder\api.cpp(491): note: see declaration of 'fail'

[yi zhang]

Thanks! I use a newer revision cb1c34a and find that this issue has been fixed.

[Ashok Kumar Mishra]

The issue has been resolved.