Fail to build for AARCH64 and ARMHF

[Christian Marillat]

Thanks for the new release, but this version doesn’t build for amr64.

Debian unstable arm64 (board is pine 64)

Build fail for 10 and 12 bits only.

I can provide the full log if needed.

‌/home/marillat/build/x265-dmo-3.4/source/common/aarch64/asm-primitives.cpp: In function ‘void x265_12bit::setupAssemblyPrimitives(x265_12bit::EncoderPrimitives&, int)’:
<command-line>: error: ‘x265_12bit_pixel_satd_4x4_neon’ was not declared in this scope; did you mean ‘x265_pixel_satd_4x4_neon’?

/home/marillat/build/x265-dmo-3.4/source/common/aarch64/asm-primitives.cpp: In function ‘void x265_10bit::setupAssemblyPrimitives(x265_10bit::EncoderPrimitives&, int)’:
<command-line>: error: ‘x265_10bit_pixel_satd_4x4_neon’ was not declared in this scope; did you mean ‘x265_pixel_satd_4x4_neon’?

And I’ve never noticed before but the build fail also on armhf arm+NEON

In file included from /home/marillat/x265-dmo-3.4/source/common/primitives.h:36,
                 from /home/marillat/x265-dmo-3.4/source/common/arm/asm-primitives.cpp:29:
/home/marillat/x265-dmo-3.4/source/common/arm/asm-primitives.cpp: In function ‘void x265_12bit::setupAssemblyPrimitives(x265_12bit::EncoderPrimitives&, int)’:
<command-line>: error: ‘x265_12bit_ssim_4x4x2_core_neon’ was not declared in this scope; did you mean ‘x265_ssim_4x4x2_core_neon’?

‌

[th0ma7]

getting similar error as well. Cross-compiling using SynoCommunity framework and enabling ASM fails similary to this.

[Torrekie]

Same error on iOS arm64 native build

/buildroot/multicoreware-x265_git-f0c1022b6be1/source/common/aarch64/asm-primitives.cpp:104:33: error: use of undeclared identifier 'x265_10bit_pixel_satd_4x4_neon'; did you mean 'x265_pixel_satd_4x4_neon'?
        p.pu[LUMA_4x4].satd   = PFX(pixel_satd_4x4_neon);
                                ^~~~~~~~~~~~~~~~~~~~~~~~
                                x265_pixel_satd_4x4_neon

Configured with

cmake -S source/ -B x265-10bit \
  -DCMAKE_BUILD_TYPE=Release \
  -DCMAKE_SYSTEM_NAME=Darwin \
  -DCMAKE_SYSTEM_PROCESSOR=aarch64 \
  -DCMAKE_CROSSCOMPILING=false \
  -DCMAKE_INSTALL_PREFIX=/usr \
  -DCMAKE_INSTALL_RPATH=/usr \
  -DCMAKE_INSTALL_NAME_TOOL=/usr/bin/install_name_tool \
  -DCMAKE_VERBOSE_MAKEFILE=ON \
  -DCMAKE_INSTALL_SYSCONFDIR=/etc \
  -DENABLE_CLI=OFF \
  -DENABLE_SHARED=OFF \
  -DEXPORT_C_API=OFF \
  -DHIGH_BIT_DEPTH=ON \
  -DENABLE_PIC=ON \
  -DENABLE_HDR10_PLUS=ON \
  -DENABLE_LIBNUMA=OFF

Error occurs when ENABLE_HDR10_PLUS defined