bloated png by using 'Save snapshot' from preview
Issue #38
new
Hi, i'm trying to create Source vs Encode comparison.
when i'm taking snapshots from preview screen, the output png is bloated and around 6MB (for 1080p file). even if the encode is 50% size of the Source, the Source's png and the Encode's png is in the same bloated size.
(in avsPmod the PNGs is in different size, and around 2-3MB for 1080p file)
Thank you for this awesome software!
Comments (6)
-
-
repo owner
Thing is: it’s Qt that is saving the image. Qt is pretty much this project’s only dependency. I can not influence .png saving in it, and doing it with other means would involve drawing more dependencies. I don’t want to do that. I don’t see how this is a critical bug. If snapshot size is so critical to you - you could save as WebP.
-
bug can be fixed by changing quality factor to -1 while saving.
bool success = m_framePixmap.save(snapshotFilePath, format, -1);
(ref: https://doc.qt.io/qt-5/qpixmap.html#save)
PR: https://bitbucket.org/mystery_keeper/vapoursynth-editor/pull-requests/12/fix-bloated-png-bug/diff
-
repo owner
Wonderful. I didn’t know that. Thank you very much!
I’ll fix it as soon as I get to it.
No to the pull request, because different argument should be used for PNG and WebP.
-
Yes, you are right.WebP should have 100 as quality. -1 is resulting in size <100kb.
I think you can fix this with a if-else.
Happy to help.
Thank you very much for developing this awesome software.
-
If anyone cant wait for the patch in master/release:
Here’s a (Dirty) build with ‘-1’ patch. (NOTE: WebP implementation is not correct, resulting in very small size of picture. should be fixed by @Aleksey Lyashin in master soon)
https://www.dropbox.com/s/rk6hps6bsjdf3t0/release-64bit-gcc.rar?dl=0
- Log in to comment
any update on this?
this is a critical bug.