Commits

John Mulligan committed 73623df

fslib: check return code of dup in C

Comments (0)

Files changed (1)

     reslist = PyList_New(0);
     if (reslist == NULL) return NULL;
 
-    dirh = fdopendir(dup(dirfd));
+    dirfd = dup(dirfd);
+    if (dirfd < 0) {
+        Py_XDECREF(reslist);
+        PyErr_SetFromErrno(PyExc_OSError);
+        return NULL;
+    }
+    dirh = fdopendir(dirfd);
     if (dirh == NULL) {
         Py_XDECREF(reslist);
         PyErr_SetFromErrno(PyExc_OSError);
         return NULL;
     }
 
+    dirfd = dup(dirfd);
+    if (dirfd < 0) {
+        PyErr_SetFromErrno(PyExc_OSError);
+        return NULL;
+    }
     Py_BEGIN_ALLOW_THREADS
-    temp = fdopendir(dup(dirfd));
+    temp = fdopendir(dirfd);
     Py_END_ALLOW_THREADS
     if (temp == NULL) {
         PyErr_SetFromErrno(PyExc_OSError);
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.