Nathan Taylor avatar Nathan Taylor committed 2f5063c

changed assertion to ValueError

Comments (0)

Files changed (2)

pypy/rlib/parsing/ebnfparse.py

                     real_expansions.append(expansion)
                     real_changes.append(change)
                     continue
-                assert n != len(expansion), (
-                    "Rule %r's expansion needs at least one "
-                    "symbol with >0 repetitions" % rule.nonterminal)
+                if n == len(expansion):
+                    raise ValueError("Rule %r's expansion needs "
+                        "at least one symbol with >0 repetitions"
+                        % rule.nonterminal)
                 slices = []
                 start = 0
                 for i, (maybe, symbol) in enumerate(

pypy/rlib/parsing/test/test_ebnfparse.py

 IGNORE: " ";
 foo: "A"?;
 """
-    excinfo = py.test.raises(AssertionError, parse_ebnf, grammar)
-    assert "Rule 'foo'" in str(excinfo.value)
+    excinfo = py.test.raises(ValueError, parse_ebnf, grammar)
+    assert "foo" in str(excinfo.value)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.