Change solution for issue#164

Johan Olsen avatarJohan Olsen created an issue

Hello,

I had the issue #164, and tried the fix for it. On some of my code however, this gave some errors at the end of the coverage run. It turns out that this is to my code defining its own cmp on classes derived from threading.Thread. I use this to be able to sort threads on my own. I use this test code:

import threading

class MyThread (threading.Thread):

    def __init__(self, num):
        self.num = num
        threading.Thread.__init__(self)

    def run(self):
        print "Hello %s, %s" % (self.num, self.ident)

    def __cmp__(self, other):
        return cmp(self.num, other.num)

thr1 = MyThread(1)
thr2 = MyThread(2)
thr1.start()
thr2.start()
thr2.join()
thr1.join()

and get this printouts / traceback:

coverage run cover_test.py
Hello 1, 7028
 Hello 2, 6292
Traceback (most recent call last):
  File "C:\Python27\Scripts\coverage-script.py", line 8, in <module>  
    load_entry_point('coverage==3.6', 'console_scripts', 'coverage')()  
  File "c:\Python27\lib\site-packages\coverage\cmdline.py", line 710, in main  
    status = CoverageScript().command_line(argv)
  File "c:\Python27\lib\site-packages\coverage\cmdline.py", line 429, in command_line
    self.do_execute(options, args)
  File "c:\Python27\lib\site-packages\coverage\cmdline.py", line 565, in do_execute
    self.coverage.stop()
  File "c:\Python27\lib\site-packages\coverage\control.py", line 374, in stop
    self.collector.stop()
  File "c:\Python27\lib\site-packages\coverage\collector.py", line 287, in stop
    self.pause()
  File "c:\Python27\lib\site-packages\coverage\collector.py", line 299, in pause
    tracer.stop()
  File "c:\Python27\lib\site-packages\coverage\collector.py", line 127, in stop
    if self.thread != threading.currentThread():
  File "cover_test.py", line 13, in __cmp__
    if self.num > other.num:
AttributeError: '_MainThread' object has no attribute 'num'

I suggest to replace
if self.thread != threading.currentThread():
with
if self.thread.ident != threading.currentThread().ident:
in collector.py, which I think will solve this problem.

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.