File handling bug on PyPy (4.0 regression it seems)

Issue #411 resolved
Ionel Cristian Mărieș
created an issue

It appears that on PyPy coverage will randomly fail to load data files. I suspect there's improper file handling somewhere (implicit close instead of using .close() or context manager api).

Examples:

I had even more failed builds like those but they passed after rerun - which leads me to the conclusion that coverage don't properly handle file closing.

Comments (10)

  1. Ned Batchelder repo owner

    My own test suite occasionally prints a warning during the PyPy tests about unclosed files, but I have never been able to track it down. I just checked all of the uses of open(), and they all seem solid to me. If you can find one to fix, I'm happy to do it.

  2. Log in to comment