1. Ned Batchelder
  2. coverage.py
  3. Pull requests

Pull requests

#18 Declined
Repository
Deleted repository
Branch
default (24bbaea46fb7)
Repository
coverage.py
Branch
default

* Implement live filtering of index table rows

Author
  1. Danny Allen
Reviewers
Description
No description

Comments (7)

  1. Ned Batchelder repo owner

    I'll take a look at the functionality provided, I'm sorry it's taken so long. I'd strongly prefer that you don't make tangential stylistic changes as part of the same pull request: it only adds noise to the review, and provides more issues for us to have to resolve. Why change single quotes to double quotes, why change the style of invoking the ready functions, why change the braces in the css?

    1. Danny Allen author

      The context of my code is that I did it internally inside an organisation, and rather than leave this useful functionality locked away, I decided to contribute it here in the spirit of open source. This is why the code style of additional things was changed - it is because I didn't start this with the thought of contributing it, so I wrote it in my preferred style.