#61 Open
Repository
coverage.py
Branch
json_command
Repository
coveragepy
Branch
default

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r json_command https://bitbucket.org/atodorov/coverage.py
hg merge json_command
hg commit -m 'Merged in atodorov/coverage.py/json_command (pull request #61)'
Author
  1. Alexander Todorov
Reviewers
Description

Here is another take on PR #60. This time implementing a separate json command which dumps the report into a JSON format instead of human readable text.

Comments (4)

  1. Alexander Todorov author

    Btw the latest write looks like this:

            # Write the data to the file.
            file_obj.write(self._GO_AWAY)
            json.dump(file_data, file_obj)
    

    Maybe if we get rid of the _GO_AWAY header and include the numbers of all/missing statements and branches the need for a separate command will go away.

    OTOH I'm working with data from older versions (pickle format) and the new command helped me convert it to JSON (that is before merging with the default branch).

  2. Ned Batchelder repo owner

    Thanks, I can take a look at this soon. The json data file is explicitly not a supported format (which is why _GO_AWAY is there), and will not be turned into a reporting format.

  3. Ned Batchelder repo owner

    @andreif The data file is for my own internal use, and I reserve the right to change it as needed. If we want a JSON report format, we can make one that is explicitly supported, though it may still be different than the data file.