1. Andy Mikhailenko
  2. argh
  3. Pull requests

Pull requests

#1 Merged
Repository
Deleted repository
Branch
default (a756c116d7a2)
Repository
argh
Branch
default

Fixed helpers.confirm not working in python3. Fixes #14.

Author
  1. madjar
Reviewers
Description

Just a little fix to make confirm work with python 3. The problem didn't appear in the tests because raw_input is always mocked.

No tests with this fix because input() is quite hard to test, as it taps directly into stdin. The fix should be simple enough to be manually checked, though.

With python 3, it defines raw_input as a simple wrapper that decode its argument before passing it to input. The decoding is needed because the arg to raw_input is encoded, and is thus of type bytes in python 3.

  • Issues #14: confirm does not work on python 3 resolved

Comments (0)