Chaos Mod: Flashlight locks the game in OpenGL with KM's new GL_Upload32

[Frank Sapone]

I haven't played our other mods in a good long while that we ported and noticed in OpenGL turning on the flashlight with "cmd flashlight" will lock the game. It's not 3DFX/Mesa/Sage/whatever related as it happens in Windows on modern machines as well. Haven't looked at the code yet to see why.

[Frank Sapone]

Offending code is ent->client->flashlight->s.modelindex = gi.modelindex ("models/objects/dummy/tris.md2"); which is necessary for the flashlight, if its omitted there is no light and it no longer functions in software.

[Frank Sapone]

If I add that model to precache at the beginning the game will lock up loading it as well in opengl on map load

[Frank Sapone]

Bug is in ref_gl at memcpy ((char )pheader + pheader->ofs_skins, (char )pinmodel + pheader->ofs_skins, pheader->num_skins*MAX_SKINNAME);

[Frank Sapone]

Bug is actually somewhere in the NEW GL_Upload32 by KM; using the original GL_Upload32 has no issues.

[Frank Sapone]

Infinite loop bug in non_power_of_two code.