Commits

Alexandre Rossi committed 0216547

do not crash on bad encoding of EXIF Artist

Comments (0)

Files changed (3)

lazygal/metadata.py

 
     def get_authorship(self):
         try:
-            return self.get_exif_string('Exif.Image.Artist')
+            author = self.get_exif_string('Exif.Image.Artist')
+            return self._fallback_to_encoding(author)
         except KeyError:
             return ''
 
Add a comment to this file

lazygaltest/sample-author-badencoding.jpg

Added
New image

lazygaltest/test_metadata.py

         im_md = metadata.ImageInfoTags(self.get_sample_path(sample))
         self.assertEqual(im_md.get_focal_length(), '18.0 mm (35 mm equivalent: 27.0 mm)')
 
+    def test_authorship(self):
+        sample = 'sample-author-badencoding.jpg'
+        im_md = metadata.ImageInfoTags(self.get_sample_path(sample))
+        self.assertEqual(im_md.get_authorship(), u'\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd \ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd')
+
 
 if __name__ == '__main__':
     unittest.main()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.