Commits

Sarah Richardson committed ca4ad1a

criticisms

Comments (0)

Files changed (2)

lib/Bio/GeneDesign.pm

   my ($self, $seqarg, $type, $enz_allowed) = @_;
 
   $enz_allowed = $enz_allowed || 0;
-  my @seqs = ref($seqarg) eq "ARRAY" ? @$seqarg  : ($seqarg);
+  my @seqs = ref $seqarg eq 'ARRAY' ? @$seqarg  : ($seqarg);
   my @list;
   foreach my $seq (@seqs)
   {
     my $str = $seq;
-    my $ref = ref($seq);
+    my $ref = ref $seq;
     if ($ref)
     {
       my $bit = $self->_checkref($seq, $enz_allowed);
       $self->throw("object $ref is not a compatible object $bit") if ($bit < 1);
-      $str = ref($seq->seq)  ? $seq->seq->seq  : $seq->seq;
+      $str = ref $seq->seq  ? $seq->seq->seq  : $seq->seq;
     }
     push @list, uc $str;
   }
-  return \@list if ($type eq "ARRAY");
+  return \@list if ($type eq 'ARRAY');
   return $list[0];
 }
 

lib/Bio/GeneDesign/Basic.pm

   my $prseq = uc $ntseq;
   my (@SEED, @NEW) = ((), ());
   my $offset = 0;
-  my $ntlen = length($prseq);
+  my $ntlen = length $prseq;
   while ($offset < $ntlen)
   {
-    my $template = substr($prseq, $offset, 1);
+    my $template = substr $prseq, $offset, 1;
     my $ntides = $NTIDES{$template};
-    my $possibilities = scalar(@$ntides);
+    my $possibilities = scalar @$ntides;
     if ($possibilities == 1)
     {
       @SEED = ( $template ) if ($offset == 0);