[JOSS review] Other small issues in the documentation

Issue #14 resolved
Pi-Yueh Chuang created an issue

Here are two miscellaneous/small issues and questions:

  1. typo at File format: Boleans -> Booleans

  2. I'm wondering if IPCS-A and IPCS-D are common names in the community? If not, I think it may be a good idea to put a reference behind them so that users can have a reference. I can see many people using the term IPCS in the community of finite element methods, but I hardly see people using the terms IPCS-A and IPCS-D. From my understanding of the documentation, IPCS-A refers to the method similar to the one in Perot, J. B. (1993). An analysis of the fractional step method. Journal of Computational Physics, 108(1), 51-58.? And IPCS-D refers to Chorin/Temam-style fractional methods that discretization happens after applying fractional step to the PDE?

Comments (2)

  1. Tormod Landet

    Thanks for reporting!

    1. Will fix now
    2. I have a paper about to go up on arXiv with description and comparison of the algebraic and differential implementations of IPCS (focus on mass conservation), I will leave this issue open until I have got a pre-print to link to for clarification. Should be up in a few days.
  2. Tormod Landet

    Preprint ref + hyphenation

    Add a preprint reference and hyphenate some compound adjectives.

    Fixes issue 14 by referencing the preprint for descriptions of IPCS-A and IPCS-D.

    → <<cset 6b4b2515fb88>>

  3. Log in to comment