[JOSS review] Apache license version 2.0

[Pi-Yueh Chuang]

I see you put a short boilerplate notice of some sort of copyright messages in your LICENSE file. But I'm not sure this is the correct way to do it.

I'm not 100% sure, but according to my googling, I think you should keep only the Apache license terms in the LICENSE file without any modification. As for those copyright content, you probably will want to have them in another file called NOTICE and also have them in each of your source code files.

The following is an example from OpenNTF: https://www.openntf.org/Internal/home.nsf/dx/Applying_Apache_License

And also http://www.apache.org/legal/src-headers.html

[Tormod Landet]

Thanks for looking into this. It does seem like every source code file should have a header and not only a note in the README plus a LICENSE file which I have currently. I will go for the short SPDX header version shown here: http://www.apache.org/foundation/license-faq.html#Apply-My-Software

# Copyright 2019 Tormod Landet
# SPDX-License-Identifier: Apache-2.0

I will have to research a bit about putting a note in the LICENSE file, I see that e.g. page 14 in this presentation seems to encourage it: https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf Of course it must be very clear that it is a note and not a part of the actual license

[Tormod Landet]

All files now carry a license header, and the LICENSE file contains only the Apache-2.0 license