Fix for issue 749: Some Code methods update data but not the ref flag

Declined
#264 · Created  · Last updated

Declined pull request

Manually copied to dev and commited. Not sure how to update the code in an existing pull request.

Closed by: ·2018-11-26

Description

I am confident about the changes in Code.

But I am not sure about AbstractMarkupFilter. It does some weird stuff: a method updates outerData, then the caller copies the outerData to data and clears outerData.

I think there is something fishy there, but I am not sure what the right fix is. So I have done something that I think makes it work the same as before this change.

Anyone familiar with AbstractMarkupFilter, please take a look, you are my only hope :-)

Mihai

0 attachments

0 comments

Loading commits...