Fix for issue 749: Some Code methods update data but not the ref flag
Mihai Nita
Branch: mihai_code_constructor
Branch: dev
Declined
Declined pull request
Manually copied to dev and commited. Not sure how to update the code in an existing pull request.
Closed by: Mihai Nita·2018-11-26
I am confident about the changes in
Code
.But I am not sure about
AbstractMarkupFilter
. It does some weird stuff: a method updatesouterData
, then the caller copies theouterData
todata
and clearsouterData
.I think there is something fishy there, but I am not sure what the right fix is. So I have done something that I think makes it work the same as before this change.
Anyone familiar with
AbstractMarkupFilter
, please take a look, you are my only hope :-)Mihai