Issue #24 resolved

XPathExprOr is broken except in simple cases

Anonymous created an issue

In PyQuery 0.7 simple CSS selectors like "a, span" work, but more complex ones like ".parent a, .parent span" don't work. This is because AdvancedXPathExprOr overwrites the prefix of its children.

Here is a patch that fixes the bug:

{{{ class AdvancedXPathExprOr(XPathExprOr): def init(self, items, prefix=None): self.prefix = prefix = prefix or '' self.items = items self.prefix_prepended = False

def __str__(self):
    if not self.prefix_prepended:
        # We cannot prepend the prefix at __init__ since it's legal to
        # modify it after construction. And because __str__ can be called
        # multiple times we have to take care not to prepend it twice.
        prefix = self.prefix or ''
        for item in self.items:
            item.prefix = prefix+(item.prefix or '')
        self.prefix_prepended = True
    return ' | '.join([str(i) for i in self.items])

}}}