XPathExprOr is broken except in simple cases

Anonymous avatarAnonymous created an issue

In PyQuery 0.7 simple CSS selectors like "a, span" work, but more complex ones like ".parent a, .parent span" don't work. This is because AdvancedXPathExprOr overwrites the prefix of its children.

Here is a patch that fixes the bug:

class AdvancedXPathExprOr(XPathExprOr):
    def __init__(self, items, prefix=None):
        self.prefix = prefix = prefix or ''
        self.items = items
        self.prefix_prepended = False

    def __str__(self):
        if not self.prefix_prepended:
            # We cannot prepend the prefix at __init__ since it's legal to
            # modify it after construction. And because __str__ can be called
            # multiple times we have to take care not to prepend it twice.
            prefix = self.prefix or ''
            for item in self.items:
                item.prefix = prefix+(item.prefix or '')
            self.prefix_prepended = True
        return ' | '.join([str(i) for i in self.items])
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.