PyQuery constructor from filename fails

Jeff Lowdermilk avatarJeff Lowdermilk created an issue

Not sure why this hasn't been discovered yet, except perhaps no one uses the 'filename' kwarg. Fix is simple. In pyquery/pyquery.py:

155 156 if kwargs: 157 # specific case to get the dom 158 if 'filename' in kwargs: 159 - html = open(kwargs['filename']) 159 + html = open(kwargs['filename']).read() 160 elif 'url' in kwargs:.

Just needs that and a test to exercise this path in the constructor.

Comments (2)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.