1. Ondřej Doněk
  2. TagsSidebar
  3. Issues
Issue #5 resolved

Querying doesn't work with new versions of Firefox

Fabrice Thiroux
created an issue

I've changed a few things in sidebar.js to make it work.

        this.getBookmarksForSelectedTags = function() {
            let queryOptions = this.historySrv.getNewQueryOptions();
            let query = this.historySrv.getNewQuery();
    -       query.tags = this.selectedTags;
    -
    +       let bmfolder = this.bookmarksSrv.bookmarksMenuFolder;
    +       let ubfolder = this.bookmarksSrv.unfiledBookmarksFolder;
    +       let tbfolder = this.bookmarksSrv.toolbarFolder;
    +       query.searchTerms = this.selectedTags.sort();
    +       query.setFolders([ubfolder,bmfolder,tbfolder], 3);
    +
            return this.historySrv.executeQuery(query, queryOptions);
        }; // end TagsSidebar.getBookmarksForSelectedTags()

And for sorting tags

        let query = this.historySrv.getNewQuery();
        let tagsFolder = this.bookmarksSrv.tagsFolder;
        query.setFolders([tagsFolder], 1);
-
+       options.sortingMode = options.SORT_BY_KEYWORD_ASCENDING;
+
        return this.historySrv.executeQuery(query, options);
    }; // end TagsSidebar.getTags()

Comments (5)

  1. Fabrice Thiroux reporter

    Hi, Ondřej.

    Does it still work? I have issue with Firefox 38.0.1. I didn't look further, though.

    Sorry, Can't help you for the minimal version number. It worked with Firefox 36.0.1.

  2. Log in to comment