OpenID4VCI: typos in draft 11, from Section 7 to the end
7.2. Credential Request, the 2nd paragraph
conveyd → conveyed
// Change “conveyd” to “conveyed”.
11.1.4. Credential Lifecycle Management, the 1st paragraph
the Credential Issuer → The Credential Issuer
// Capitalize “t” of “the” at the beginning of the paragraph.
12.3. Multiple Accesses to the Credential Endpoint, the 2nd paragraph
the Credential Issuer → The Credential Issuer
// Capitalize “t” of “the” at the beginning of the paragraph.
is no longer be valid → is no longer valid
// Remove “be”.
12.4. Relationship between the Credential Issuer Identifier in the metadata and the Issuer Identifier in the Issued Credential, the 2nd list item
{#credential-issuer-identifier}
→ (#credential-issuer-identifier)
// Replace {
and }
with (
and )
so that the markdown can be processed as intended.
D.2. Credential Offer - Cross-Device (with information pre-submitted by the End-User)
User scans the QR code → The End-User scans the QR code
// Change “User” to “The End-User”
E.1.1.6. Credential Response, the 1st paragraph
MUST be a JSON string → MUST be a JWT
// Change “JSON string” to “JWT”.
E.1.1.6. Credential Response, the example
"format": "ldp_vc"
→ "format": "json_vc_jwt"
// Change "ldp_vc"
to "json_vc_jwt"
.
E.1.2.2. Credential Issuer Metadata, the 1st paragraph
Appendix E.1.3.2 apply → Appendix E.1.1.2 apply
// Change “E.1.3.2” to “E.1.1.2” (if my guess is correct).
E.1.2.3. Credential Offer, the 1st paragraph
Appendix E.1.3.3 apply → Appendix E.1.1.3 apply
// Change “E.1.3.3” to “E.1.1.3” (if my guess is correct).
E.1.2.4. Authorization Details, the 1st paragraph
Appendix E.1.3.3 apply → Appendix E.1.1.4 apply
// Change “E.1.3.3” to “E.1.1.4” (if my guess is correct).
E.1.2.5. Credential Request, the 1st paragraph
Appendix E.1.3.5 apply → Appendix E.1.1.5 apply
// Change “E.1.3.5” to “E.1.1.5” (if my guess is correct).
E.1.3.3. Credential Offer, the bullet for @context
Append a period at the end of the sentence.
E.2.2. Credential Issuer Metadata, the example, display[1].locale
"jp-JA"
→ "ja-JP"
// Change "jp-JA"
to "ja-JP"
. “ja” means “Japanese” (language). “JP” means “Japan” (country).
E.2.3. Credential Offer, the bullet for doctype
Append a period at the end of the sentence.
E.2.4. Authorization Details, the bullet for doctype
Append a period at the end of the sentence.
E.2.4. Authorization Details, the bullet for claims
Append a period at the end of the sentence.
E.2.5. Credential Request, the bullet for doctype
Append a period at the end of the sentence.
E.2.5. Credential Request, the bullet for claims
Append a period at the end of the sentence.
Comments (4)
-
-
reporter - Appendix E.1.1.x sections are for
jwt_vc_json
. - Appendix E.1.2.x sections are for
jwt_vc_json-ld
. - Appendix E.1.3.x sections are for
ldp_vc
.
With the following reasons,
- Referring to E.1.3.x in E.1.2.x results in referring to what has not been mentioned yet.
- The content of E.1.2.x (
jwt_vc_json-ld
) is probably closer to the content of E.1.1.x (jwt_vc_json
) than the content of E.1.3.x (ldp_vc
).
I guessed that each E.1.2.x section should refer to the corresponding E.1.1.x section instead of the corresponding E.1.3.x section.
- Appendix E.1.1.x sections are for
-
@Takahiko Kawasaki understood, the references are in fact correct for this section as the credential being signed is JSON-LD based. To address your feedback what I have done is re-organised the order so there is no reference to a section before it is defined, please see the updated PR 466
-
- changed status to resolved
PR merged
- Log in to comment
@Takahiko Kawasaki , thanks I have raised PR https://bitbucket.org/openid/connect/pull-requests/466 however I was struggling to understand what you meant for the following, can you clarify?