[OID4VCI] credential request example is wrong (editorial issue)
Issue #1950
resolved
The credential request example in Section 7.2. Credential Request of OID4VCI is as follows.
{
"format":"jwt_vc_json",
"types":[
"VerifiableCredential",
"UniversityDegreeCredential"
],
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTplYmZlYjFmNzEyZWJjNmYxYzI3NmUxMmVjMjEva2V5cy8
xIiwiYWxnIjoiRVMyNTYiLCJ0eXAiOiJKV1QifQ.eyJpc3MiOiJzNkJoZFJrcXQzIiwiYXVkIjoiaHR
0cHM6Ly9zZXJ2ZXIuZXhhbXBsZS5jb20iLCJpYXQiOiIyMDE4LTA5LTE0VDIxOjE5OjEwWiIsIm5vbm
NlIjoidFppZ25zbkZicCJ9.ewdkIkPV50iOeBUqMXCC_aZKPxgihac0aW9EkL1nOzM"
}
}
However, it should be as follows instead to align with the example in E.1.1.5. Credential Request of the latest snapshot in the Git repository (examples/credential_request_jwt_vc_json_with_claims.json). In short, "types"
should be placed under "credential_definition"
.
{
"format":"jwt_vc_json",
"credential_definition":{
"types":[
"VerifiableCredential",
"UniversityDegreeCredential"
]
},
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTplYmZlYjFmNzEyZWJjNmYxYzI3NmUxMmVjMjEva2V5cy8
xIiwiYWxnIjoiRVMyNTYiLCJ0eXAiOiJKV1QifQ.eyJpc3MiOiJzNkJoZFJrcXQzIiwiYXVkIjoiaHR
0cHM6Ly9zZXJ2ZXIuZXhhbXBsZS5jb20iLCJpYXQiOiIyMDE4LTA5LTE0VDIxOjE5OjEwWiIsIm5vbm
NlIjoidFppZ25zbkZicCJ9.ewdkIkPV50iOeBUqMXCC_aZKPxgihac0aW9EkL1nOzM"
}
}
Likewise, the batch credential request example in Section 8.1. Batch Credential Request:
{
"credential_requests":[
{
"format":"jwt_vc_json",
"types":[
"VerifiableCredential",
"UniversityDegreeCredential"
],
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTpl...C_aZKPxgihac0aW9EkL1nOzM"
}
},
{
"format":"mso_mdoc",
"doctype":"org.iso.18013.5.1.mDL",
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZ...KPxgihac0aW9EkL1nOzM"
}
}
]
}
should be changed to:
{
"credential_requests":[
{
"format":"jwt_vc_json",
"credential_definition":{
"types":[
"VerifiableCredential",
"UniversityDegreeCredential"
]
},
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTpl...C_aZKPxgihac0aW9EkL1nOzM"
}
},
{
"format":"mso_mdoc",
"doctype":"org.iso.18013.5.1.mDL",
"proof":{
"proof_type":"jwt",
"jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZ...KPxgihac0aW9EkL1nOzM"
}
}
]
}
Comments (2)
-
-
- changed status to resolved
PR merged
- Log in to comment
Thank you! addressed in PR #528 https://bitbucket.org/openid/connect/commits/7240924d43b1e74f1712b0031ffc34cb09f7d708