More examples as an appendix

Issue #124 closed
Nat Sakimura created an issue

On the 2017-10-03 call, Pam relayed the request from OB to add more examples to the FAPI specs. The callers agreed to do it as an appendix to the spec.

Comments (12)

  1. Nat Sakimura reporter

    Joseph to create a set of examples from conformance suite, then Dave is going to do the follow ups.

  2. Joseph Heenan

    This might take me slightly longer than expected as it turns out all the examples I have are RS256, whereas we only allow PS256.

  3. Joseph Heenan

    Here’s some examples:

    request object

    (This requests acr is an essential claim as per ID2. As we’ve removed the acr related clauses we might want to remove that part of the request?)

    jarm response

    private_key_jwt client assertion

    front channel id token response

    Are there any others we need?

    These are taken from:

    https://www.certification.openid.net/log-detail.html?log=xT6j6SAKqj&public=true (openid)

    https://www.certification.openid.net/log-detail.html?log=ri4Vzw5iW1&public=true (jarm)

  4. Dave Tonge

    Merged in part2-examples (pull request #182)

    Add non-normative examples of various objects

    • Add non-normative examples of various objects

    As described in #124, these are real examples taken from runs of the conformance suite, meaning they are hopefully correct.

    closes #124

    • Update examples

    • replace hostnames with example.org ones

    • remove some acr claims as FAPI no longer mandates their use

    • Update the examples as per feedback on MR

    See https://bitbucket.org/openid/fapi/pull-requests/182/add-non-normative-examples-of-various/diff

    closes #124

    Approved-by: Dave Tonge

    → <<cset e9f79ccf1d13>>

  5. Dave Tonge

    Merged in part2-examples (pull request #182)

    Add non-normative examples of various objects

    • Add non-normative examples of various objects

    As described in #124, these are real examples taken from runs of the conformance suite, meaning they are hopefully correct.

    closes #124

    • Update examples

    • replace hostnames with example.org ones

    • remove some acr claims as FAPI no longer mandates their use

    • Update the examples as per feedback on MR

    See https://bitbucket.org/openid/fapi/pull-requests/182/add-non-normative-examples-of-various/diff

    closes #124

    Approved-by: Dave Tonge

    → <<cset e9f79ccf1d13>>

  6. Log in to comment