Defensive change to avoid crashing on weird large Excel files

Issue #579 resolved
Aigars Mahinovs
created an issue

In file openpyxl / workbook / names / line 127:

  • node_text = name_node.text
  • node_text = name_node.text or ''

This change avoided a crash and the data loaded from the files without further problems. Can not reproduce with other files and the ones that produce the bug are confidential :)

Comments (5)

  1. CharlieC

    Thanks but what are we supposed to do with this?

    definedNames are scheduled for a complete rewrite in 2.4 so this won't be relevant. How about a PR (with tests!) for 2.3?

  2. Log in to comment