Defensive change to avoid crashing on weird large Excel files
Issue #579
resolved
In file openpyxl / workbook / names / named_range.py line 127:
- node_text = name_node.text
- node_text = name_node.text or ''
This change avoided a crash and the data loaded from the files without further problems. Can not reproduce with other files and the ones that produce the bug are confidential :)
Comments (5)
-
-
- changed version to 2.3.x
I'll see what I can do about that next week. Prevented from actually contributing by an arcane copyright assignment clause right now :(
-
Thanks. I know it's a trivial change but doing it myself means having to think up a test case.
-
- changed status to resolved
This is resolved in 2.4.
-
- removed version
Removing version: 2.3.x (automated comment)
- Log in to comment
Thanks but what are we supposed to do with this?
definedNames are scheduled for a complete rewrite in 2.4 so this won't be relevant. How about a PR (with tests!) for 2.3?