__getitem__ breaking change

Issue #872 invalid
Daniel Keller created an issue

The change in commit dee6655 breaks code which assumes that the return type of Worksheet.__getitem__ is an iterator (for instance by calling next() on it). This change is not mentioned in the documentation.

Comments (3)

  1. CharlieC

    Sounds like the code making the assumption is broken: an iterator was never promised. The use of __getitem__ is clearly documented.

  2. CharlieC

    For reliable, programmatic access that return an iterable the iter_rows() and iter_cols() methods are provided.

  3. Log in to comment