- changed milestone to 0.4.4
Exports fail for @dplatten
Exports are failing on the line
e = e.filter(**{f[filt].name + '__' + f[filt].lookup_type : filterdict[filt]})
Doesn't matter which filters, as long as there are some.
Comments (17)
-
reporter -
reporter Testing shows that there seems to be a list coming through, which then trips up
filterdict[filt]
There may also be some empty values.
Proposed fix from @dplatten
for filt in f: if filt in filterdict and filterdict[filt]: if (filterdict[filt])[0] <> '': e = e.filter(**{f[filt].name + '__' + f[filt].lookup_type : (filterdict[filt])[0]})
-
reporter - changed title to Exports for @DPlatten
-
reporter - changed title to Exports fail for @dplatten
-
reporter Fix proposed by @dplatten for export failures on his install. Checks for empty first values and assumes a list rather than a string. Refs
#123.→ <<cset fe30a0cc831b>>
-
reporter If filterdict[filt] is a unicode/string then using the [0] will of course just get the first character. Hence test for string, then if not assume list. Refs
#123.→ <<cset 38706cd169b3>>
-
reporter Remove print statement. Tested with Ubuntu system wide installed and on @dplatten's Windows system wide install. Refs
#123→ <<cset 6c5cfc78f3d2>>
-
reporter Added comment to explain the list test and reference the issue. Refs
#123.→ <<cset 9e71879d3139>>
-
reporter Applied mod to check for lists as per ctxlsx. Refs
#123.→ <<cset 45bffe466ee1>>
-
reporter Applied mod to check for lists in the nhsbsp mammo export as per ctxlsx. Refs
#123.→ <<cset 9d2f9ee2e910>>
-
reporter Mammo csv exports are using a different variable name - s instead of e. Should probably clean this up at some point. Refs
#123.→ <<cset 8581a37c5aad>>
-
reporter Merge message should have said (forgot --no-ff): Additional code added to filter code to check for lists. Tested with CT xlsx on Ubuntu and @dplatten's Windows install, tested csv mg, fluoro and CT on Ubuntu and csv nhsbsp on Ubuntu. Fixes
#123. -
reporter - changed status to resolved
-
reporter Added ref
#123to CHANGES, added 120s and 130s to the links.→ <<cset 99aff8b3636f>>
-
reporter - changed milestone to 0.5.0
-
reporter - changed status to open
Interim non-working version of code has slipped back into xlsx.py in 0.5.0b1
-
reporter - changed status to resolved
Putting the fixed code for export filtering back in to ctxlsx. Fixes
#123again.→ <<cset f8cf4c0f0499>>
- Log in to comment