- changed component to Import: Radiographic
Multiple values in filter thickness causes ValueError
Carestream have two values in the filter thickness fields when both Copper and Aluminium is in use.
The field is a Decimal String value representation, so two numbers with a comma in the middle is not permitted, and causes pydicom to bomb out with a ValueError as it can't convert the string to a float.
Comments (12)
-
reporter -
reporter Added try/except ValueError to filter thickness to gracefully handle Carestream use of two comma separated decimals in a Decimal String field. Commented out code that was to deal with the string that I can't get hold of. Refs
#137.→ <<cset 6e0cc2cc0d91>>
-
reporter Asked as question asked on pydicom forum: https://groups.google.com/forum/?hl=en-GB#!topic/pydicom/x_WsC2gCLck
-
reporter - changed status to resolved
Filter thickness values are now extracted from the ValueError message, then converted to a list. Fixes
#137→ <<cset 7dd58a51af68>>
-
reporter Doesn't consider multiple values with other delimiters such as \
-
reporter Added ref
#137to changes doc.→ <<cset 0ea92c26fa16>>
-
reporter - changed status to open
Method used to resolve is deprecated.
Use Darcy's method instead.
-
reporter - changed status to resolved
Replaced deprecated error message processing with Darcy's suggestion. Should fix
#137but needs testing.→ <<cset 4cba4e8cf1a2>>
-
reporter Tested successfully but discovered that the modal only allows for two decimal places. Created issue
#154to address.Issue with max and min in the wrong fields is directly from the source data.
-
reporter -
assigned issue to
-
assigned issue to
-
reporter Moved the filters preparation into a distinct function so that it can be properly tested. Employed more black magic to create the illegal values to be tested. See https://groups.google.com/d/topic/pydicom/x_WsC2gCLck/discussion. Refs
#137and to an extent refs#431.→ <<cset 81de698fd04f>>
-
reporter Changes to properly test ref
#137by factoring out _xray_filters_prep means single filter extracts can now be tested. Modified test_dx_imports accordingly.→ <<cset 937d3c7e7706>>
- Log in to comment