Multiple values in filter thickness causes ValueError

Issue #137 resolved
Ed McDonagh created an issue

Carestream have two values in the filter thickness fields when both Copper and Aluminium is in use.

The field is a Decimal String value representation, so two numbers with a comma in the middle is not permitted, and causes pydicom to bomb out with a ValueError as it can't convert the string to a float.

Comments (12)

  1. Ed McDonagh reporter

    Added try/except ValueError to filter thickness to gracefully handle Carestream use of two comma separated decimals in a Decimal String field. Commented out code that was to deal with the string that I can't get hold of. Refs #137.

    → <<cset 6e0cc2cc0d91>>

  2. Ed McDonagh reporter

    Tested successfully but discovered that the modal only allows for two decimal places. Created issue #154 to address.

    Issue with max and min in the wrong fields is directly from the source data.

  3. Ed McDonagh reporter

    Changes to properly test ref #137 by factoring out _xray_filters_prep means single filter extracts can now be tested. Modified test_dx_imports accordingly.

    → <<cset 937d3c7e7706>>

  4. Log in to comment