Remove sorting links and instructions for histogram plots
Consider removing the sorting links and instructions when in the histogram plots, as they have not function in that mode.
Comments (30)
-
-
- changed milestone to 0.7.0
-
assigned issue to
-
Added css and some JavaScript to hide the sorting links and instructions when viewing CT-related histograms. References issue
#358.→ <<cset 3f78d3570939>>
-
Adding code similar to below after both the showing and hiding of the sorting instructions ensures that the histogram plot occupies as much of the div as it can.
if (chartFullScreen == true) { enterFullScreen('collapseTwo', 'histogramAcquisitionPlotDLPdiv'); enterFullScreen('collapseTwo', 'histogramAcquisitionPlotDLPdiv'); }
-
More generically, the following code can be used in all charts:
if (chartFullScreen == true) { enterFullScreen($('#'+this.renderTo.id).parent().parent()[0].id, this.renderTo.id); enterFullScreen($('#'+this.renderTo.id).parent().parent()[0].id, this.renderTo.id); }
-
Ensured that histograms occupy the full available space when viewing full-screen. References issue
#358→ <<cset 3f916621876d>>
-
Added size refresh code and instruction hiding code to all charts where appropriate. There's something not quite right about this at the moment, as for some charts the
full screen
button moves about. References issue#358→ <<cset 45951b69f392>>
-
The djp demo site is now up-to-date with this code
-
Fixed the problem I mentioned earlier with the position of the
full-screen
button. References issue#358→ <<cset cacafedd65ff>>
-
DJP demo site up-to-date again.
-
reporter A bug has been introduced that occurs on my local install and on the djp demo site. With DLP per acquisition and CDTIvol per acquisition plotted, the DLP chart works as it is supposed to.
If the DLP chart is in default bar-chart mode, when the CTDIvol chart goes to histogram mode the DLP chart gains a normalise button, and the CTDIvol chart doesn't.
Both charts have the sorting options removed in histogram mode as desired.
-
Fixed bug with normalise button on CTDI charts. References issue
#358→ <<cset 9a1ee214595d>>
-
reporter As far as I have seen in my testing, this is complete. I haven't looked at DX though.
-
Thanks. Is the transition from main plot to histogram and back again OK? There's a couple of resizes that are run during the transitions that I thought might introduce a visual glitch.
-
reporter Didn't notice anything, and the chart I have up now just has the averages over time, for which I have just discovered you can deselect series to remove them from the chart! Lovely.
I've got to head off now - I'll have a look again tomorrow.
-
When returning to the main chart from a histogram the series do not return to their correct colour. This is due to the resize update taking place too early. Needs moving to the end of the drill down and drill up bits of JavaScript code.
Update: it's not the resize taking place to early, it's the timeout around the resize.
-
Fixed glitch where main series didn't return to the correct colour when going back from viewing histogram. References issue
#358→ <<cset 6de165852d9c>>
-
Fixed bug in two radiographic charts that was stopping normalisation button from being hidden on return from viewing a histogram. References issue
#358→ <<cset 86c4b708fd74>>
-
Put the timeout back in to the full screen resize as this seems to prevent the problem I have seen where the main series doesn't display with the correct series colour when returning from viewing a histogram. References issue
#358→ <<cset 704306e980aa>>
-
I cannot make the main series always return to their correct shades when returning from viewing s histogram. I've tried building in delays for each
enterFullScreen
, and also tried a 0setTimeout
, which should allow the JavaScript to catch up (see here), but nothing seems to work. I'm going to remove the updateFullScreen function. This will mean that the histograms will have a little blank space below them when viewed in full-screen. -
- changed status to resolved
Removed resize of histograms when viewing in full-screen mode. Fixes the problem I've been having with the main series not returning to the correct colour after a histogram has been viewed. References and fixes issue
#358→ <<cset eeeac52b24e2>>
-
Added css and some JavaScript to hide the sorting links and instructions when viewing CT-related histograms. References issue
#358.→ <<cset 3f78d3570939>>
-
Ensured that histograms occupy the full available space when viewing full-screen. References issue
#358→ <<cset 3f916621876d>>
-
Added size refresh code and instruction hiding code to all charts where appropriate. There's something not quite right about this at the moment, as for some charts the
full screen
button moves about. References issue#358→ <<cset 45951b69f392>>
-
Fixed the problem I mentioned earlier with the position of the
full-screen
button. References issue#358→ <<cset cacafedd65ff>>
-
Fixed bug with normalise button on CTDI charts. References issue
#358→ <<cset 9a1ee214595d>>
-
Fixed glitch where main series didn't return to the correct colour when going back from viewing histogram. References issue
#358→ <<cset 6de165852d9c>>
-
Fixed bug in two radiographic charts that was stopping normalisation button from being hidden on return from viewing a histogram. References issue
#358→ <<cset 86c4b708fd74>>
-
Put the timeout back in to the full screen resize as this seems to prevent the problem I have seen where the main series doesn't display with the correct series colour when returning from viewing a histogram. References issue
#358→ <<cset 704306e980aa>>
-
Removed resize of histograms when viewing in full-screen mode. Fixes the problem I've been having with the main series not returning to the correct colour after a histogram has been viewed. References and fixes issue
#358→ <<cset eeeac52b24e2>>
- Log in to comment
Hi @edmcdonagh. This is easy to do, and a good idea. I'll sort it for 0.7.0.