NULL values in remapp_generalstudymoduleattr for Enhanced SR
Issue #463
resolved
Enhanced SR's, not coming from a GE CT, and not being a dose report, result in empty lines (NULL/FALSE everywhere) in table "remapp_generalstudymoduleattr", causing the displayed number of studies in the database to be incorrect. In our database it's roughly 50% of all studies. Anonymized sample data attached.
Comments (21)
-
-
reporter
no problem!
-
reporter
Perhaps check for (0008,0070) Manufacturer = GE Medical Systems?
-
In the mean time, if you are comfortable working your way around the models, you might like to do something similar to these instructions on how to delete everything, but instead find some value that enables you to isolate all the false studies.
Something like:
from remapp.models import GeneralStudyModuleAttr a = GeneralStudyModuleAttr.objects.all() b = a.filter(generalequipmentmoduleattr__stationname__exact='yourstationname') b.count() b.delete()Usual provisos apply - do a backup first!
-
Renaming GE sample files to indicate that they are Enhanced SR objects and not Radiation Dose SR objects. Refs
#463→ <<cset 1da780b52e35>>
-
Referencing the new names for the GE test objects in the test. Refs
#463→ <<cset 602b6f8e714e>>
-
New import test for GE Enhanced Structured Reports before making changes for ref
#463→ <<cset a3dda8da0bde>>
-
Added tests for second GE ESR file. Refs
#463→ <<cset 56133f20ee7f>>
-
- changed status to resolved
Very simple change in the end to fix
#463! Should probably return silently with a log message if required though.→ <<cset 334289522102>>
-
Adding an abbreviated version of the enhanced structured report that shouldn't be imported. Refs
#463.→ <<cset b87969d30f91>>
-
- changed milestone to 0.8.0
- changed component to Import: RDSR
-
assigned issue to
Ed McDonagh
-
changes and CHANGES for ref
#463→ <<cset c6931bdd683d>>
-
changes and CHANGES for ref
#463→ <<cset c89c79a67391>>
-
Added ESR note to release changes. Refs
#463Added @LaurenceKing and @tcdewit to docs.→ <<cset 17717020c0a3>>
-
New import test for GE Enhanced Structured Reports before making changes for ref
#463→ <<cset a3dda8da0bde>>
-
Added tests for second GE ESR file. Refs
#463→ <<cset 56133f20ee7f>>
-
Very simple change in the end to fix
#463! Should probably return silently with a log message if required though.→ <<cset 334289522102>>
-
Adding an abbreviated version of the enhanced structured report that shouldn't be imported. Refs
#463.→ <<cset b87969d30f91>>
-
changes and CHANGES for ref
#463→ <<cset c6931bdd683d>>
-
changes and CHANGES for ref
#463→ <<cset c89c79a67391>>
-
Added ESR note to release changes. Refs
#463Added @LaurenceKing and @tcdewit to docs.→ <<cset 17717020c0a3>>
- Log in to comment
Thanks for the report and the sample file. Can I add it to the test_files please?
I need to improve the identification of GE Enhanced SR objects, shouldn't be difficult to do.