link to data from histogram tooltips doesn't work properly at the moment

[David Platten]

Links in mean DAP and DLP histogram plots take the user to more days than they should.

[David Platten]

I've looked at this again this morning and can't see a problem. It may be that my browser was using a cached JavaScript file for the plots. It would be good if someone else checked to see if they think the links from the histogram tooltips take you to the correct data.

Thanks.

[Ed McDonagh]

Which branch @dplatten?

I'm not sure how soon I can do this, but I'll try. So you think there may have been a problem where the tooltip links didn't respect the date filters?

[David Platten]

Any branch with the recently-changed GETs will do. The problem may have been date filtering or study name filtering when viewing an acquisition plot.

[David Platten]

This seems to work fine now.

[Ed McDonagh]

Will there be equivalent links from the CTDIvol histograms?

[David Platten]

It's not possible to link from the CTDIvol histograms as there is no filter defined for CTDIvol at the moment. If I added a new filter then yes, it would be trivial to add the links. I was a little reluctant to add CTDIvol filters as the filter list is already a little congested on the CTfiltered.html page. Do you know if it is possible to make a filter hidden on the page, but still be active?

[Ed McDonagh]

I see, makes sense. Don't know is the answer to your question!

[David Platten]

I tried searching to answer my question a few weeks ago and couldn't find an answer.

[David Platten]

Looks like I wasn't too thorough with my earlier search: there's a "HiddenInput" option that I think I'd be able to use: https://docs.djangoproject.com/en/1.8/ref/forms/widgets/

[David Platten]

There is a problem with the links from histogram tooltips if the protocol or study name includes an ampersand (&) symbol. This is escaped to "&", but not then unescaped in the underlying views.py code, preventing the database filtering from working.

[David Platten]

There is a problem with the links from histogram tooltips if the protocol or study name includes an ampersand (&) symbol. This is escaped to "&", but not then unescaped in the underlying views.py code, preventing the database filtering from working.

[David Platten]

Added string replace to swap & for %26. This fixes issue 205.

→ <<cset f51623564201>>

[David Platten]

I think it may be more elegant, and still work, if I processed the text contained in requestResults that is sent to view.py rather than in the chart JavaScript. Something like the code below may work.

import HTMLParser
import urllib

myString = "Head & spine"
h = HTMLParser.HTMLParser()
myStringUnescaped = h.unescape(myString)
print myStringUnescaped

myStringRecoded = urllib.quote_plus(myStringUnescaped)
print myStringRecoded

# Or in fewer lines
myStringNew = urllib.quote_plus(h.unescape(myString))
print(myStringNew)

This will also catch other possible problems that I haven't encountered yet.

[David Platten]

I don't think my earlier idea about unescaping & in python is a good one. I can't seem to get it to work, so I'm leaving it as it is - a simple text replace in the JavaScript of each chart