Radiographic kVp and mAs plots sometimes fail

Issue #301 resolved
David Platten created an issue

Radiographic plots of average kVp and mAs per acquisition protocol sometimes fail. This occurs when there are more protocols with kVp or mAs data than there are protocols with DAP data. This has come to light due to a new x-ray system temporarily stopping populating the DAP field, but continuing to populate the kVp and mAs fields.

This is happening because the number of iterations in a for loop in (lines 413 to 470) is controlled by the number of acquisition protocols that have a DAP value.

It would be solved by replacing the single for loop with three others: one for the DAP, one for the kVp and one for the mAs data.

I've marked the bug as "minor" because I think it's unlikely to affect a user.

Comments (8)

  1. David Platten reporter

    Separated a single for loop into three so that plots of average DAP, kVp and mAs work correctly when they have different numbers of acquisition protocols. Also corrected some if logic so that DAP, mAs and kVp data are only calculated when required. Fixes issue #301

    → <<cset fa0e6c947f34>>

  2. Ed McDonagh

    Bitbucket has been really unstable in the last few days :(

    Looks like it has all come through now :)

  3. Log in to comment