Add a button to each chart to make it full-screen
I would find it useful to be able to view the charts full-screen sometimes.
Comments (17)
-
reporter -
Presumably you'll do this for CT as well, and then close? In which case it should be in 0.7 shouldn't it?
-
reporter Changed endif back as per Ed's comment. References issue
#306.→ <<cset d2f60bd53481>>
-
reporter I do plan to implement this for CT too. I think that some of my JavaScript is Chrome-specific at the moment - it needs to be checked on some other browsers before I sort out the CT charts too.
-
Ok. If there is any possibility it won't make the cut (and perhaps anyway, just for good practice), can you fork it into a new branch? Else we might need to try and extract it to make a release...
Thanks.
-
reporter Added full screen buttons to CT charts. Moved JavaScript into external file. Tested and works with Chrome. Edge and Firefox also work, but charts don't revert back to their original height when exiting full screen view. References issue
#306→ <<cset 68ce7c8eabcd>>
-
reporter Using bootstrap method to toggle fullscreen. Doesn't go to full screen height at the moment. References issue
#306→ <<cset 7f05e3241bf8>>
-
reporter Charts now return to their correct height once exiting full-screen mode. Tested with Chrome 46 and Internet Explorer 8. I'll test on other browsers at home, and if they work OK I'll close the issue. References issue
#306.→ <<cset f7bd50cb72d8>>
-
reporter @edmcdonagh, I've updated http://djp-openremdemo.rhcloud.com/ with the full-screen chart code. You may have to flush your browser cache for it to update the css and JavaScript. Let me know what you think.
-
reporter I can confirm that the current code works on Firefox too.
-
reporter - changed milestone to 0.7.0
-
Lovely. Only looked in Chrome at the moment, but lovely.
Different issue, but can you remove the inconsistency that opening I think the second chart closes the first, concertina style, but the others don't?
-
reporter Hi @edmcdonagh. I've fixed that annoying inconsistency - see commit a291209.
-
Thanks!
-
reporter The full-screen code also works fine in Safari on a MacBook Pro.
@edmcdonagh, are you happy for me to merge this branch back into develop?
-
reporter - changed status to resolved
Tested as working in: Internet Explorer 8 Firefox Chrome Safari Edge
-
Please do merge back in
- Log in to comment
Added a little JavaScript and a button to each radiographic chart to make it full-screen. References issue
#306→ <<cset 99a960c42f98>>