Add a button to each chart to make it full-screen

Issue #306 resolved
David Platten created an issue

I would find it useful to be able to view the charts full-screen sometimes.

Comments (17)

  1. Ed McDonagh

    Presumably you'll do this for CT as well, and then close? In which case it should be in 0.7 shouldn't it?

  2. David Platten reporter

    I do plan to implement this for CT too. I think that some of my JavaScript is Chrome-specific at the moment - it needs to be checked on some other browsers before I sort out the CT charts too.

  3. Ed McDonagh

    Ok. If there is any possibility it won't make the cut (and perhaps anyway, just for good practice), can you fork it into a new branch? Else we might need to try and extract it to make a release...


  4. David Platten reporter

    Added full screen buttons to CT charts. Moved JavaScript into external file. Tested and works with Chrome. Edge and Firefox also work, but charts don't revert back to their original height when exiting full screen view. References issue #306

    → <<cset 68ce7c8eabcd>>

  5. David Platten reporter

    Charts now return to their correct height once exiting full-screen mode. Tested with Chrome 46 and Internet Explorer 8. I'll test on other browsers at home, and if they work OK I'll close the issue. References issue #306.

    → <<cset f7bd50cb72d8>>

  6. David Platten reporter

    @edmcdonagh, I've updated with the full-screen chart code. You may have to flush your browser cache for it to update the css and JavaScript. Let me know what you think.

  7. Ed McDonagh

    Lovely. Only looked in Chrome at the moment, but lovely.

    Different issue, but can you remove the inconsistency that opening I think the second chart closes the first, concertina style, but the others don't?

  8. David Platten reporter

    The full-screen code also works fine in Safari on a MacBook Pro.

    @edmcdonagh, are you happy for me to merge this branch back into develop?

  9. Log in to comment