- changed milestone to 0.8.0
-
assigned issue to
Use display name table to delete unwanted studies
Studies that get on the system that are not of interest or not useful, such as imported studies or CR studies, could all be deleted along with their entry in the display name table.
Comments (17)
-
reporter -
reporter This is actaully the issue I should have been referencing with all the recent commits, rather than issue
#479 -
reporter See also pull request #149
-
reporter Adding refs
#318,#580to changes→ <<cset ade0149799e9>>
-
Adjusted the layout of text and buttons on the study review page to suit my taste. References issue
#318and perhaps issue#580→ <<cset 22ba36efa973>>
-
@edmcdonagh, apologies - my recent commit has broken the buttons...
-
reporter I don't see how?
The other thing I didn't end up doing was to change the behaviour of the 'cancel' button - currently it implements the 'back' function, which isn't really what you want unless you happen to have reloaded the page pressing the delete studies button...
-
reporter I see - you deleted the named span elements that are replaced with the AJAX to insert the form.
-
Fixing the buttons that I just broke. References issue
#318and perhaps issue#580→ <<cset a4c394420ed7>>
-
reporter The reason I shifted it to the right was because I didn't want it to just be part of a block of text. It needs to stand out in some way and break the flow.
How about throwing it all in a panel: https://getbootstrap.com/docs/3.3/components/#panels-alternatives ?
And the spelling mistake @LuukO pointed out ("ths equipment" instead of "this equipment") remains.
What do you think? I'd have a go but that would mean tidying up my
#114code to commit it or stashing it to checkout this branch... -
I think a panel would be fine for me.
-
I've put the text and buttons for the
Study deletion
section of the study review page in a panel. I've chosen aninfo
panel class as the colour of the heading is similar to what is used on the DICOM networking page. References issue#318and perhaps issue#580→ <<cset 9472948ad62f>>
-
reporter That works for me. Thanks.
-
reporter - changed status to resolved
Merged in issue580rfanddx (pull request #149)
Fixes
#580,#318RF/DX and deleting studiesDocumentation is outstanding (see issue ref
#583)→ <<cset 2eb379749d97>>
-
reporter Three issues with this as it stands:
- Deleting a lot of studies can take more than 30 seconds it seems, which might lead to breakages!
- I was thinking there should be a button to re-evaluate with a different modality filter or none. But that function exists I guess by finding the same entry in the different tables of the display names page.
- The documentation doesn't indicate this, and doesn't indicate that if you delete you will only delete those in the current filter (current modality).
-
reporter Clarified what happens when a study has more than one modality. Changed docs link to deletions page from display name page. Refs
#318,#583→ <<cset 4cfdb64f39d3>>
-
reporter Merged in issue583docs4displaynamesAndDeleting (pull request #170)
Issue583docs4displaynamesAndDeleting
→ <<cset 77cabb887da8>>
- Log in to comment