Use display name table to delete unwanted studies

Issue #318 resolved
Ed McDonagh created an issue

Studies that get on the system that are not of interest or not useful, such as imported studies or CR studies, could all be deleted along with their entry in the display name table.

Comments (17)

  1. Ed McDonagh reporter

    This is actaully the issue I should have been referencing with all the recent commits, rather than issue #479

  2. Ed McDonagh reporter

    I don't see how?

    The other thing I didn't end up doing was to change the behaviour of the 'cancel' button - currently it implements the 'back' function, which isn't really what you want unless you happen to have reloaded the page pressing the delete studies button...

  3. Ed McDonagh reporter

    I see - you deleted the named span elements that are replaced with the AJAX to insert the form.

  4. Ed McDonagh reporter

    The reason I shifted it to the right was because I didn't want it to just be part of a block of text. It needs to stand out in some way and break the flow.

    How about throwing it all in a panel: https://getbootstrap.com/docs/3.3/components/#panels-alternatives ?

    And the spelling mistake @Luuk pointed out ("ths equipment" instead of "this equipment") remains.

    What do you think? I'd have a go but that would mean tidying up my #114 code to commit it or stashing it to checkout this branch...

  5. David Platten

    I've put the text and buttons for the Study deletion section of the study review page in a panel. I've chosen an info panel class as the colour of the heading is similar to what is used on the DICOM networking page. References issue #318 and perhaps issue #580

    → <<cset 9472948ad62f>>

  6. Ed McDonagh reporter

    Three issues with this as it stands:

    1. Deleting a lot of studies can take more than 30 seconds it seems, which might lead to breakages!
    2. I was thinking there should be a button to re-evaluate with a different modality filter or none. But that function exists I guess by finding the same entry in the different tables of the display names page.
    3. The documentation doesn't indicate this, and doesn't indicate that if you delete you will only delete those in the current filter (current modality).
  7. Log in to comment