Simplification of chart data processing
The JavaScript for chart series calculation / series population is very similar for the plots of average dose per study / acquisition protocol / request. It should be possible to reduce the code by writing a function that does the calculations. It may also be possible to simplify the code in views.py too.
Comments (30)
-
reporter -
reporter Corrected typo that was preventing a CT chart from working. References issue
#351→ <<cset 00380251d69d>>
-
reporter The JavaScript has now been simplified for the CT and radiographic plots. It doesn't look so straight-forward for
views.py
, but I'll take another look at it. -
reporter Updated series labels of average plots so that
(mean)
or(median)
is added to the series labels when plotting both mean and median values. It's so good to be able to update the code in one place and know that all the charts of this type will be up-to-date with the change (thanks, issue#351). References issue#332and issue#351.→ <<cset 38b9ffa6aebf>>
-
reporter - changed status to resolved
The chart JavaScript has been greatly simplified by using a single function to update each type of chart. Updating the code of one of these functions enables all charts of that type to be updated.
-
reporter Simplified chart data processing by moving most work to functions. These functions are used by both CT and DX charts. References issue
#351and issue#332.→ <<cset ca599113abb7>>
-
reporter Corrected typo that was preventing a CT chart from working. References issue
#351→ <<cset 00380251d69d>>
-
reporter Updated series labels of average plots so that
(mean)
or(median)
is added to the series labels when plotting both mean and median values. It's so good to be able to update the code in one place and know that all the charts of this type will be up-to-date with the change (thanks, issue#351). References issue#332and issue#351.→ <<cset 38b9ffa6aebf>>
-
reporter -
assigned issue to
-
assigned issue to
-
reporter Moved calculations of data for radiographic average plots with histogram to a function. References issue
#351→ <<cset 028a95546ecc>>
-
reporter - changed status to open
-
reporter Radiographic plots over time now calculated using a function. References issue
#351→ <<cset d1439d2340ef>>
-
reporter CT plot over time now calculated using a function. References issue
#351→ <<cset 917fc26a47e0>>
-
reporter Workload charts now use a function. Possibly all done now. References issue
#351→ <<cset b32c2bbf729e>>
-
reporter - changed status to resolved
Finishing touches to moving all chart calculations to functions. Every chart of a given type now uses the same function to calculate the required data, whether radiographic or CT. Will help if the routines need changing, or if new charts need to be added. Fixes issue
#351.→ <<cset b6696f8cdaf0>>
-
reporter - changed milestone to 0.7.0
-
reporter moved chart calculation functions to a seperate file. References issue
#351→ <<cset 8f11511b95df>>
-
reporter Fixed bug with CTDI plotting. Also altered name of min and max DAP variables to be generic. References issue
#351→ <<cset 293f93aed931>>
-
reporter Created single JavaScript function to create charts of average vs category. Will be able to use this single function for all charts of this type, meaning that lots of JavaScript files can be removed. To begin with, I've replaced the CTDI and DLP per acquisition protocol with the function. The rest to follow. References issue
#351→ <<cset c6ca92a013ff>>
-
reporter Replaced the remaining CT charts of dose vs category with the new function. References issue
#351→ <<cset 610862badf56>>
-
reporter - changed status to open
Using JavaScript functions for charts, rather than lots of individual files.
-
reporter Replaced all radiographic chart JavaScript files of average vs category with the new function. Amended CT use of the function to include new parameter. References issue
#351→ <<cset 0708eac57670>>
-
reporter Purely reformatting: no functional changes. I've run PyCharm's
auto-indent lines
command on each file. References issue#351→ <<cset a4e187ed9930>>
-
reporter Replaced all over-time plot JavaScript files with a single function. References issue
#351→ <<cset b77094c29a92>>
-
reporter Replaced all frequency plot JavaScript files with a single function. References issue
#351→ <<cset 0a440373a836>>
-
reporter Renamed the chart variable to a generic name. References issue
#351→ <<cset e1a1f250fb6c>>
-
reporter Replaced both workload plot JavaScript files with a single function. References issue
#351→ <<cset ec50ec2c2c12>>
-
reporter - changed status to resolved
All chart JavaScript files are now generic functions, rather than plot-specific files.
-
reporter Updated change files. References issue
#351→ <<cset d68e55246849>>
-
Merging chart simplification branch. Great job @dplatten! I'll test it properly after merging it in. Refs
#351,#360→ <<cset 138e952ea942>>
- Log in to comment
Simplified chart data processing by moving most work to functions. These functions are used by both CT and DX charts. References issue
#351and issue#332.→ <<cset ca599113abb7>>