1. OpenREM
  2. OpenREM
  3. OpenREM
  4. Issues

Issues

Issue #358 resolved

Remove sorting links and instructions for histogram plots

Ed McDonagh
created an issue

Consider removing the sorting links and instructions when in the histogram plots, as they have not function in that mode.

Comments (30)

  1. David Platten

    Adding code similar to below after both the showing and hiding of the sorting instructions ensures that the histogram plot occupies as much of the div as it can.

                        if (chartFullScreen == true) {
                            enterFullScreen('collapseTwo', 'histogramAcquisitionPlotDLPdiv');
                            enterFullScreen('collapseTwo', 'histogramAcquisitionPlotDLPdiv');
                        }
    
  2. David Platten

    More generically, the following code can be used in all charts:

                        if (chartFullScreen == true) {
                            enterFullScreen($('#'+this.renderTo.id).parent().parent()[0].id, this.renderTo.id);
                            enterFullScreen($('#'+this.renderTo.id).parent().parent()[0].id, this.renderTo.id);
                        }
    
  3. David Platten

    Added size refresh code and instruction hiding code to all charts where appropriate. There's something not quite right about this at the moment, as for some charts the full screen button moves about. References issue #358

    → <<cset 45951b69f392>>

  4. Ed McDonagh reporter

    A bug has been introduced that occurs on my local install and on the djp demo site. With DLP per acquisition and CDTIvol per acquisition plotted, the DLP chart works as it is supposed to.

    If the DLP chart is in default bar-chart mode, when the CTDIvol chart goes to histogram mode the DLP chart gains a normalise button, and the CTDIvol chart doesn't.

    Both charts have the sorting options removed in histogram mode as desired.

  5. David Platten

    Thanks. Is the transition from main plot to histogram and back again OK? There's a couple of resizes that are run during the transitions that I thought might introduce a visual glitch.

  6. Ed McDonagh reporter

    Didn't notice anything, and the chart I have up now just has the averages over time, for which I have just discovered you can deselect series to remove them from the chart! Lovely.

    I've got to head off now - I'll have a look again tomorrow.

  7. David Platten

    When returning to the main chart from a histogram the series do not return to their correct colour. This is due to the resize update taking place too early. Needs moving to the end of the drill down and drill up bits of JavaScript code.

    Update: it's not the resize taking place to early, it's the timeout around the resize.

  8. David Platten

    Put the timeout back in to the full screen resize as this seems to prevent the problem I have seen where the main series doesn't display with the correct series colour when returning from viewing a histogram. References issue #358

    → <<cset 704306e980aa>>

  9. David Platten

    I cannot make the main series always return to their correct shades when returning from viewing s histogram. I've tried building in delays for each enterFullScreen, and also tried a 0 setTimeout, which should allow the JavaScript to catch up (see here), but nothing seems to work. I'm going to remove the updateFullScreen function. This will mean that the histograms will have a little blank space below them when viewed in full-screen.

  10. David Platten

    Added size refresh code and instruction hiding code to all charts where appropriate. There's something not quite right about this at the moment, as for some charts the full screen button moves about. References issue #358

    → <<cset 45951b69f392>>

  11. David Platten

    Put the timeout back in to the full screen resize as this seems to prevent the problem I have seen where the main series doesn't display with the correct series colour when returning from viewing a histogram. References issue #358

    → <<cset 704306e980aa>>

  12. David Platten

    Removed resize of histograms when viewing in full-screen mode. Fixes the problem I've been having with the main series not returning to the correct colour after a histogram has been viewed. References and fixes issue #358

    → <<cset eeeac52b24e2>>

  13. Log in to comment