Reduce use of global variables in skin dose map JavaScript; improve JavaScript objects

Issue #414 resolved
David Platten
created an issue

Some of the skin dose map JavaScript functions rely on certain global variables being set. It would be better to pass these data to the functions as a parameter.

The methods within the JavaScript objects use this a great deal, referring to properties of the object. Pycharm Doesn't like this, and would prefer some clarification in the code. See http://javascriptplayground.com/blog/2012/04/javascript-variable-scope-this/

Comments (10)

  1. David Platten reporter

    Forgot to upload the updated rffiltered.html file with the previous commit. Updated skin dose map JavaScript code to reduce use of global variables in functions and also clarify use of this in objects. Pycharm is much happier with my code now. References issue #414

    → <<cset c4882d4f7a5d>>

  2. David Platten reporter

    Updated some skin dose map JavaScript to use jQuery rather than the document model. Added a few bits of documentation. Components that could have been affected by the changes have all been verified as still working. References issue #414

    → <<cset a101bc2017ae>>

  3. Log in to comment