DX with multiple filters in MultiValue format fails to import
See https://bitbucket.org/elenhinan/openrem/pull-requests/1/attributeerror-multivalue-object-has-no/diff
Applies to images from Carestream Health DRX-Evolution
Comments (27)
-
reporter -
reporter Adding some test code for the filter materials extraction for DX. Refs
#431and pull request #53→ <<cset b4de7280afbe>>
-
reporter Test now makes sure materials are correctly recorded. Refs
#431and pull request #53→ <<cset bc497efc8f92>>
-
reporter Non-significant adding of spaces to dx.py. Added tests for DRX Evolution MultiValue filters and for a single filter. Refs
#431and pull request #53→ <<cset 244c49d5c81a>>
-
reporter Correcting the test for DRX Evolution with MulitpleValue format materials. Refs
#431, pull request #53→ <<cset 6a447c0ac9b2>>
-
reporter Attempt to fix the filter import to cope with both old Kodak way of doing it and new Carestream way of doing it! Refs
#431→ <<cset 99cf76b791d1>>
-
reporter Single filters were strings that were being split into letters. Hopefully fixes this. Refs
#431→ <<cset a03ee30c83c6>>
-
reporter Thicknesses are of type DPfloat, shouldn't have tried for [0].. Refs
#431→ <<cset 7ed620fb653e>>
-
reporter Removed code for single filter within the multi-filter function as it is dealt with elsewhere. Refs
#431→ <<cset 477cf5f759e1>>
-
reporter - changed milestone to 0.7.4
-
assigned issue to
Changing to 0.7.4 bug-fix release
-
reporter Bringing ref
#431changes into 0.7.4 bug-fixing release . Need to test in 0.7.4.→ <<cset 685f6f61dcd4>>
-
reporter Merging ref
#431fixes into release-0.7.4b1→ <<cset 558b3755e29e>>
-
reporter - changed status to resolved
Tested by @elenhinan, confirmed working in his pull request
-
reporter Factoring out code that deals with multiple filters to enable testing and fixing of the code. Refs
#431and PR #53→ <<cset 9a12061ab7ee>>
-
reporter Adding some test code for the filter materials extraction for DX. Refs
#431and pull request #53→ <<cset b4de7280afbe>>
-
reporter Test now makes sure materials are correctly recorded. Refs
#431and pull request #53→ <<cset bc497efc8f92>>
-
reporter Non-significant adding of spaces to dx.py. Added tests for DRX Evolution MultiValue filters and for a single filter. Refs
#431and pull request #53→ <<cset 244c49d5c81a>>
-
reporter Correcting the test for DRX Evolution with MulitpleValue format materials. Refs
#431, pull request #53→ <<cset 6a447c0ac9b2>>
-
reporter Attempt to fix the filter import to cope with both old Kodak way of doing it and new Carestream way of doing it! Refs
#431→ <<cset 99cf76b791d1>>
-
reporter Single filters were strings that were being split into letters. Hopefully fixes this. Refs
#431→ <<cset a03ee30c83c6>>
-
reporter Thicknesses are of type DPfloat, shouldn't have tried for [0].. Refs
#431→ <<cset 7ed620fb653e>>
-
reporter Removed code for single filter within the multi-filter function as it is dealt with elsewhere. Refs
#431→ <<cset 477cf5f759e1>>
-
reporter - changed status to open
Previous fix doesn't look suitable, and is causing one test file to generate multiple empty filters!
-
reporter Now checks if xray_filter_material is a list before launching _xray_filters_material. Corrects error where type was multiple but only included one filter material (of 0 thickness!) Refs
#431but needs testing.→ <<cset 82052e2220e2>>
-
reporter Moved the filters preparation into a distinct function so that it can be properly tested. Employed more black magic to create the illegal values to be tested. See https://groups.google.com/d/topic/pydicom/x_WsC2gCLck/discussion. Refs
#137and to an extent refs#431.→ <<cset 81de698fd04f>>
-
reporter Adding refs
#431,#450to changes. Fixes#431again.→ <<cset 0c8a136149bc>>
-
reporter - changed status to resolved
Adding refs
#431,#450to changes. Fixes#431again.→ <<cset 0c8a136149bc>>
- Log in to comment
Factoring out code that deals with multiple filters to enable testing and fixing of the code. Refs
#431and PR #53→ <<cset 9a12061ab7ee>>