Modify dx.py to correctly extract information from some more DR systems
Fuji Go digital mobiles Once imported, acquisition protocol is blank , and requested procedure name contains the acquisition protocol.
Toshiba Radrex digital rooms Acquisition protocols not imported at the moment.
Comments (21)
-
reporter -
reporter Altered study description and requested procedure name so that it works for Fuji Go mobile images. References issue
#482→ <<cset 8c5062afaeec>>
-
reporter Altered acquisition protocol extraction so that it works for Toshiba Radrex digital x-ray systems. These systems store the acquisition protocol in the ImageComments field... Sort-of references issue
#482→ <<cset a3aa6df5b060>>
-
reporter - changed title to Modify dx.py to correctly extract information from some more DR systems
- edited description
-
reporter @edmcdonagh, it looks like I've broken a test, as there is now a failure reported on the overview page. What do I need to do about that, and what does it mean?
-
reporter Simplified the if statement of my recent commit to try and resolve the failed pipeline test. References issue
#482→ <<cset a9a4e23fba0b>>
-
Hi David. It seems that https://coveralls.io has an issue, not your code, so don't worry.
Side issue - did you mean to be committing to develop?
-
reporter Hi Ed. Thanks for the reassurance. I should have created a branch... sorry. Will do so now.
-
As confirmation, I have run the test locally with your latest additions and everything works fine:
(veOpenREM)me@ubuntu:~/research/bbOpenREM$ cd openrem/ (veOpenREM)me@ubuntu:~/research/bbOpenREM/openrem$ python manage.py test remapp Creating test database for alias 'default'... .............................. ---------------------------------------------------------------------- Ran 30 tests in 32.678s OK Destroying test database for alias 'default'... (veOpenREM)me@ubuntu:~/research/bbOpenREM/openrem$
-
reporter Would you like me to revert the commits that I made to develop?
-
No, more trouble than it's worth.
-
reporter I need to make a further change. For two of our Carestream digital mobiles the requested procedure name is not populated on import. For these systems the data is present in the StudyDescription location (0008,1030). This location is already used to retrieve requested procedure names for Canon CXDI equipment studies.
-
reporter Added code to extract requested procedure name from StudyDescription location for Carestream DRX-Revolution digital mobiles. The extractor only resorts to this location if it has failed to find it in other more sensible places first. This fixes an issue with two of my digital mobiles. References issue
#482→ <<cset 70dd74bb4db4>>
-
reporter Added anonymised Carestream DRX file with image data removed. This is to be used for a test of the extractor. References issue
#482→ <<cset 4370624bc284>>
-
reporter Added a test to see if the requested procedure name is imported correctly from a skeleton Carestream DRX Revolution radiographic DICOM file. Couldn't check if this worked locally as it was unable to create a database, and then asked if it could delete my existing database. References issue
#482.→ <<cset 56075f80226a>>
-
reporter Added patient ID things to the test, as it failed due to these being missing. References issue
#482.→ <<cset 1b90b2b7cc26>>
-
Merged in issue482addToRadiographicExtractor (pull request #85)
Extract requested procedure name from StudyDescription for Carestream DRX-Revolution digital mobiles. Only resorts to this if it has failed to find it in other places first. References issue
#482→ <<cset b4b730d62f6d>>
-
reporter - changed status to resolved
I've fixed the issue I had. Close this issue for now.
-
Changes please
-
reporter Changes files updated for issue
#482. References issue#482→ <<cset 1ee15f24d38b>>
-
muchas gracias
- Log in to comment
Altered acquisition protocol extraction so that it works for Fuji Go mobile images. References issue
#482→ <<cset 2598f4dccd93>>