- edited description
Certain headers of RF-exports are missing units
Issue #498
resolved
commonheaders += [ .... 'A DAP total (Gy.m^2)', 'A Dose RP total', 'A Fluoro DAP total', 'A Fluoro dose RP total', 'A Fluoro time total', 'A Acquisition DAP total', 'A Acquisition dose RP total', 'A Acquisition time total', 'A Number of events', 'B DAP total (Gy.m^2)', 'B Dose RP total', 'B Fluoro DAP total', 'B Fluoro dose RP total', 'B Fluoro time total', 'B Acquisition DAP total', 'B Acquisition dose RP total', 'B Acquisition time total', 'B Number of events', ]
Should be replaced with
commonheaders += [ .... 'A DAP total (Gy.m^2)', 'A Dose RP total (Gy)', 'A Fluoro DAP total (Gy.m^2)', 'A Fluoro dose RP total (Gy)', 'A Fluoro time total (s)', 'A Acquisition DAP total (Gy.m^2)', 'A Acquisition dose RP total (Gy)', 'A Acquisition time total (s)', 'A Number of events', 'B DAP total (Gy.m^2)', 'B Dose RP total (Gy)', 'B Fluoro DAP total (Gy.m^2)', 'B Fluoro dose RP total (Gy)', 'B Fluoro time total (s)', 'B Acquisition DAP total (Gy.m^2)', 'B Acquisition dose RP total (Gy)', 'B Acquisition time total (s)', 'B Number of events', ]
And also filter thickness unit should be added. unit is (mm)
Comments (6)
-
reporter -
Go for it! Although I wonder if the titles should be abbreviated for clarity as column headers? (And you can do it within openrem/openrem if you choose!)
-
Modifying header to add units as per issue ref
#498. Satisfies pull request #82→ <<cset bb7244dec977>>
-
Adapted rf export test with new column titles, changed strings to unicode. Changed times from s to ms, modified various header strings to be consistent. Refs issue
#498, pull request #82.→ <<cset a9cc7e2a0e48>>
-
- changed status to resolved
-
I copied your code @LuukO so I have attributed it to you. I'll be 'rejecting' the PR though so it can close.
- Log in to comment