Address codacy issues

Issue #526 resolved

Ed McDonagh created an issue 2017-07-12

Well, some of them at least...

Comments (62)

Ed McDonagh reporter
Revamped dicom.js to suit codicy - will need to check functionality as sadly no tests for this yet. Refs ~~#526~~

→ <<cset ba62d34a5151>>
- 2017-07-12T08:41:54+00:00
Ed McDonagh reporter
Minor change to signature, prompted by codacy. Refs ~~#526~~

→ <<cset 708239c3be1b>>
- 2017-07-12T08:41:55+00:00
Ed McDonagh reporter
Minor change to signature, prompted by codacy. Fixes previous correction. Refs ~~#526~~

→ <<cset e9a6696d61d1>>
- 2017-07-12T09:18:45+00:00
Ed McDonagh reporter
Fixing a couple more of the codacy issues on dicom.js - not tested yet. Refs ~~#526~~

→ <<cset 01fb987380c8>>
- 2017-07-12T09:53:14+00:00
Ed McDonagh reporter
Modified views.py to fix most of the codacy issues. Refs ~~#526~~

→ <<cset c7c85d039cbe>>
- 2017-07-12T21:31:30+00:00
Ed McDonagh reporter
Codacy pointed out check_uid call wouldn't work. Removed main as can't think why you'd use it. Refs ~~#526~~

→ <<cset 68c9b27cc161>>
- 2017-07-12T21:56:37+00:00
Ed McDonagh reporter
Removed a load of trailing whitespaces. refs ~~#526~~

→ <<cset a3818df22df0>>
- 2017-07-12T22:16:42+00:00
Ed McDonagh reporter
Refactored export views to remove open except statements and reduce duplication. Refs ~~#526~~

→ <<cset 3360b6995d6c>>
- 2017-07-13T08:29:32+00:00
Ed McDonagh reporter
More work on exportviews. Refs ~~#526~~

→ <<cset 41e64f832056>>
- 2017-07-13T18:58:47+00:00
Ed McDonagh reporter
Removed more duplication. Refs ~~#526~~. Likely to have worse score on Codecy as I've changed the number of things it looks for...

→ <<cset 490af184b9e5>>
- 2017-07-13T18:58:47+00:00
Ed McDonagh reporter
Mostly adding in doc-string. Refs ~~#526~~

→ <<cset acf09d31e302>>
- 2017-07-13T20:35:56+00:00
Ed McDonagh reporter
Simplified if statement to bool. Refs ~~#526~~

→ <<cset 8167959cf10e>>
- 2017-07-13T20:52:23+00:00
Ed McDonagh reporter
Simplified another if statement to bool. Refs ~~#526~~

→ <<cset db56fbe81f6b>>
- 2017-07-13T21:25:46+00:00
Ed McDonagh reporter
Merged in issue526codacy (pull request #97)

Issue526codacy Refs ~~#526~~

→ <<cset 05ccc3ebfa15>>
- 2017-07-13T21:35:06+00:00
David Platten
Fixed capitalisation error. References issue ~~#526~~

→ <<cset b89bf309447f>>
- 2017-07-14T12:50:27+00:00
Ed McDonagh reporter
Correcting some errors picked up by codacy. Refs ~~#528~~, ~~#526~~

→ <<cset ce1e904055a0>>
- 2017-07-17T22:12:24+00:00
Ed McDonagh reporter
Removing unused imports, reducing line length, a little deduplication, a little better logging. Refs ~~#526~~

→ <<cset 101e6f7beb63>>
- 2017-07-18T08:32:07+00:00
Ed McDonagh reporter
Adding in missing request for new messagese. Imported messages at top of exportviews. Refs ~~#526~~

→ <<cset 94983100744e>>
- 2017-07-18T09:18:53+00:00
David Platten
Addressing some codacy issues from the previous commit. References issue ~~#526~~ and issue ~~#537~~

→ <<cset e403a1ea913d>>
- 2017-08-03T17:24:38+00:00
David Platten
Merged in issue537chartsHideSeries (pull request #105)

Addressing some codacy issues from the previous commit. References issue ~~#526~~ and issue ~~#537~~

→ <<cset 7fba25484c5d>>
- 2017-08-03T17:31:23+00:00
David Platten
Changed single to double quotes. No functional changes. References issue ~~#526~~

→ <<cset 3adb23e41fab>>
- 2017-08-11T17:37:01+00:00
Ed McDonagh reporter
Yay! https://www.codacy.com/app/OpenREM/openrem/commit?bid=4899080&cid=121187056
- 2017-08-11T17:50:59+00:00
David Platten
Swapping more single quotes for double quotes. Leaving external library code alone - just changing the OpenREM code. References issue ~~#526~~

→ <<cset 22c26ffab9ae>>
- 2017-08-14T11:23:32+00:00
David Platten
Removing some trailing whitespaces. References issue ~~#526~~

→ <<cset af002b9966b2>>
- 2017-08-14T11:23:32+00:00
David Platten
Enforcing curly bracket brace conventions for codacy. References issue ~~#526~~

→ <<cset d93cbad2cab4>>
- 2017-08-14T12:51:16+00:00
David Platten
Enforcing semicolons for codacy. References issue ~~#526~~

→ <<cset 5c9ed26eff96>>
- 2017-08-14T12:55:42+00:00
David Platten
Camel case updates. . References issue ~~#526~~

→ <<cset 217c0ff599dd>>
- 2017-08-14T15:29:02+00:00
David Platten
Shouldn't have camel-cased that field name. References issue ~~#526~~

→ <<cset 8fd5ca225787>>
- 2017-08-14T15:36:12+00:00
David Platten
Broke chart sorting in earlier commit. Fixed by this one. References issue ~~#526~~

→ <<cset 7e4fe60d4998>>
- 2017-08-14T20:18:47+00:00
David Platten
Broke chart sorting in earlier commit. Fixed by this one. References issue ~~#526~~

→ <<cset 0c8adaddb8d6>>
- 2017-08-14T20:18:48+00:00
David Platten
Further codacy updates. References issue ~~#526~~

→ <<cset 0c477cabdc19>>
- 2017-08-14T20:49:39+00:00
David Platten
Over-zealous with the single quote replacement. Making skin dose maps work again. References issue ~~#526~~

→ <<cset f6a859081dc2>>
- 2017-08-14T21:00:07+00:00
David Platten
Over-zealous with the single quote replacement. Making histogram links work again. References issue ~~#526~~

→ <<cset cad6754d91e1>>
- 2017-08-14T21:30:22+00:00
Luuk
A lot of "codacy issues" are due to trailing spaces. You can easily remove them in PyCharm by right clicking on the project root directory in the project pane. Select "Replace in Path" and use regex: [ ]+$ Replace by <empty string>.
- 2017-08-21T15:12:30+00:00
Ed McDonagh reporter
Thanks @LuukO. Do you fancy branching from this branch and committing it directly into this repo? I can then get Codacy to review the change, and by doing it in this repo directly the pipelines will run too...
- 2017-08-21T22:17:29+00:00
Luuk
Removing trailing white spaces

Using regex "[ ]+$". References issue ~~#526~~

→ <<cset b55613455ef3>>
- 2017-08-22T06:50:56+00:00
David Platten
@edmcdonagh, I've set codacy to ignore the JavaScript and css library files that are being used. The ignored .js files are now:
- boost.js
- bootstrap-datepicker.js
- bootstrap.js
- bootstrap.min.js
- chroma.min.js
- datepicker.js
- drilldown.js
- export-csv.js
- exporting.js
- highcharts.js
- html5shiv.min.js
- jquery-1.11.0.min.js
- jquery.qtip.min.js
- npm.js
- offline-exporting.js
- respond.min.js
- response.min.js
- sorttable.js
- three.min.js
The ignored css files are:
- bootstrap-theme.css
- bootstrap-theme.min.css
- bootstrap.css
- bootstrap.min.css
- datepicker3.css
- jquery,qtip.min.css
- 2017-08-22T11:07:27+00:00
David Platten
Fixing a few codacy issues. References issue ~~#526~~

→ <<cset 82d8b45ad000>>
- 2017-08-23T22:05:44+00:00
David Platten
Addressed more codacy issues. References issue ~~#526~~

→ <<cset 917b8e93bc68>>
- 2017-08-24T06:48:06+00:00
Ed McDonagh reporter
- changed status to resolved
Aded addressing Codacy issues to changes. Fixes ~~#526~~

→ <<cset 0b4510145171>>
- 2017-10-20T22:21:22+00:00
David Platten
Addressing codacy issues in skin dose map JavaScript files. References issue ~~#564~~ and issue ~~#526~~

→ <<cset fbd932b785b3>>
- 2017-11-21T19:38:20+00:00
David Platten
Addressing codacy issues in skin dose map JavaScript files. References issue ~~#526~~

→ <<cset 1a3e8c597a9a>>
- 2017-11-21T20:25:21+00:00
David Platten
Addressing codacy issues in skin dose map JavaScript files. Trying to use eslint in a couple of these files. References issue ~~#526~~

→ <<cset d1fc33e28653>>
- 2017-11-21T21:07:33+00:00
David Platten
Addressing codacy issues in skin dose map JavaScript files. Last commit tonight. References issue ~~#526~~

→ <<cset d7db848a5636>>
- 2017-11-21T21:26:07+00:00
David Platten
Addressing codacy issues in skin dose map JavaScript. References issue ~~#526~~

→ <<cset dc37ca912cc1>>
- 2017-11-22T08:52:50+00:00
David Platten
Addressing further codacy issues. References issue ~~#526~~

→ <<cset bd3b8c94ad63>>
- 2017-11-22T19:54:27+00:00
David Platten
Addressing further codacy issues. References issue ~~#526~~

→ <<cset 128ddaa7b22b>>
- 2017-11-22T20:16:20+00:00
David Platten
Addressing further codacy issues. References issue ~~#526~~

→ <<cset b2329d67c992>>
- 2017-11-22T20:26:34+00:00
David Platten
Addressing further codacy issues. References issue ~~#526~~

→ <<cset 1daf967fd3c2>>
- 2017-11-22T20:34:31+00:00
David Platten
Addressed some JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset acf10b494ed5>>
- 2017-11-24T11:09:29+00:00
David Platten
Addressed some JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset 7961346d9826>>
- 2017-11-24T12:17:00+00:00
David Platten
Trying to ignore new category of error in JavaScript. No functional changes. References issue ~~#526~~

→ <<cset 3ec2081bb3f6>>
- 2017-11-24T12:25:26+00:00
David Platten
Trying to ignore new category of error in JavaScript. No functional changes. References issue ~~#526~~

→ <<cset dc4972b88efd>>
- 2017-11-24T12:32:27+00:00
David Platten
Trying to ignore new category of error in JavaScript. No functional changes. References issue ~~#526~~

→ <<cset 69f86936b2c6>>
- 2017-11-24T12:46:44+00:00
David Platten
Trying to ignore new category of error in JavaScript. No functional changes. References issue ~~#526~~

→ <<cset 12efe011646c>>
- 2017-11-24T12:59:48+00:00
David Platten
Trying to ignore new category of error in JavaScript. No functional changes. References issue ~~#526~~

→ <<cset bb581e114524>>
- 2017-11-24T13:19:31+00:00
David Platten
@edmcdonagh, have a look at this branch on codacy...
- 2017-11-24T13:26:14+00:00
David Platten
Addressed some JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset 9812c1fed1ad>>
- 2017-11-24T13:48:40+00:00
David Platten
Addressed more JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset 8a9f7357b64b>>
- 2017-11-24T14:10:37+00:00
Ed McDonagh reporter
I'd say that was a reasonable effort!
- 2017-11-24T14:35:46+00:00
David Platten
Addressed some JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset 226485896eee>>
- 2017-11-24T14:54:59+00:00
David Platten
Addressed some JavaScript codacy issues. No functional changes. References issue ~~#526~~

→ <<cset 410ed7962e31>>
- 2017-11-24T15:06:17+00:00
Log in to comment

Assignee: Ed McDonagh

Type: bug

Priority: major

Status: resolved

Component: –

Milestone: 0.8.0

Votes: 0

Watchers: 1