Charts with categories that contain a plus symbol do not display
Part of the URLToArray
JavaScript function isn't doing what it should:
request[decodeURIComponent(pair[0])] = decodeURIComponent(pair[1]).replace(/\+/g, ' ');
needs to be replaced with
pair[1] = pair[1].replace(/\+/g, ' '); request[decodeURIComponent(pair[0])] = decodeURIComponent(pair[1]);
Comments (11)
-
reporter -
reporter - changed status to resolved
Forced all plus symbols present in the histogram bin hyperlinks to be URI encoded. Fixes issue
#535→ <<cset dfc4ab671ee0>>
-
When you want to merge this back in, please do it via a pull request, as this will automatically prompt Codacy to give it the once over... :-)
-
reporter Removing event chart code - not meant for this branch. References issue
#535→ <<cset a6270e9bbecf>>
-
reporter Updating changes files. Fixes issue
#535→ <<cset 0c65d6d50b7e>>
-
reporter - changed status to open
This change has broken the charts when no filters are in-place. Going to http://dev.openrem.org/openrem/ct/ when charts are already switched on results in empty chart
DIV
s. There needs to be atypeof pair[1] !== "undefined"
check before trying to do the string replace. Will fix at home later on today.
-
reporter Amended JavaScript to fix broken charts when no filters applied. References issue
#535→ <<cset 4b3d4be8660e>>
-
reporter Amended
views.py
to include aKeyError
for when the form data is empty - occurs when a user first goes to the CT or radiographic pages. Doesn't affect mammo or fluoro pages as they do not have a filter for acquisition protocol. References issue#535→ <<cset 66cf6cec28c8>>
-
reporter Merged in issue535chartsFailWithPlus (pull request #100)
Amended
views.py
to include aKeyError
for when the form data is empty - occurs when a user first goes to the CT or radiographic pages. Doesn't affect mammo or fluoro pages as they do not have a filter for acquisition protocol. References issue#535→ <<cset e5ba98904718>>
-
reporter - changed status to resolved
This has been fixed
-
reporter Issue
#435was marked as a duplicate of this issue. - Log in to comment
Adjusted string replacement in JavaScript function. References issue
#535.→ <<cset da6726d6b4d6>>