User can no longer click anywhere on each display name row to select it
Users used to be able to click anywhere on a display name row in order to select it (check the box on the left of the row). This doesn't work in the 0.8.0b1, almost certainly due to the tables being populated using AJAX.
Comments (12)
-
-
reporter - changed status to resolved
Fixed problem where clicking on a row in the display name table no longer resulted in that row's checkbox being toggled. It was broken by the AJAX changes. I realise I haven't created a specific branch for this, but was concerned about conflicts. Fixes issue
#609→ <<cset b254d7b97242>>
-
reporter Updating changes files. References issue
#608and issue#609→ <<cset 4ff975e6b707>>
-
This fix doesn't work for me though... I'm using v0.8.0b1 + following files from develop (for fixing sorting bug):
- review_summary_list.html
- displaynameview.html
- displayname-modality.html
- displayname-last-date.html
- displayname-count.html
-
reporter Hi Tim,
You may need to update some other files too - see:
-
We messed up the PR for this slightly, so you also need to look at the merge at 2a3c091 to see all the files you need. But where a file is mentioned in both the PR and the merge I have linked to, you need the later version from the PR. i.e. the one in develop.
Hope there is some sense in there somewhere!
-
reporter - changed status to open
Clicking on the checkbox no longer has any effect. Needs fixing.
-
reporter - changed status to resolved
Added an function to each checkbox, which brings them back to life. Their responsiveness was broken by the Ajax updating. Fixes issue
#609. Again. This is already in the changes documentation.→ <<cset c68e90017d2b>>
-
reporter Removed unrequired JavaScript now that it is added per checkbox. References issue
#609.→ <<cset 2f89e82b2350>>
-
- changed status to open
As per the other issue, opening to ensure we merge it in and don't forget it!
-
Merged in issue609unresponsiveCheckboxes (pull request #189)
Issue609unresponsiveCheckboxes
Refs
#609, already in changes from previous breakApproved-by: Ed McDonagh ed@mcdonagh.org.uk
→ <<cset 70b28e22b4fd>>
-
- changed status to resolved
Doh! After making a fuss about keeping it open until it is merged, I forgot to 'fix' it the merge message. Sorry.
- Log in to comment
Sorry