Fresh 0.9.0b5 fails - missing django-debug-toolbar-request-history package

[David Platten]

This error was received when installing in a fresh virtualenv on Ubuntu 18.04.

ImportError: No module named ddt_request_history.panels.request_history

This is fixed by:

pip install django-debug-toolbar-request-history

Can someone else confirm this is the case for them?

[David Platten]

Added missing package to setup.py. References issue #721

→ <<cset a36fb1043ffc>>

[David Platten]

Fixed conflict with changes files. May have messed up rfdetail.html. References issue #721

→ <<cset 00956dfb287c>>

[Ed McDonagh]

Hi @dplatten. I tried this whilst checking for issue #723 on linux - Ubuntu 16.04, but I think this would be the same as I was in a virtualenv... and I didn't hit the same error.

I have been considering removing the django-debug-toolbar from the setup and settings (MIDDLEWARE_CLASSES and INSTALLED_APPS). And putting instructions into the developer docs to install it and overwrite the two tuples from local_settings.py.

Or we could test it again. Or we could include it just in case.

Thoughts?

[David Platten]

I think it would be good to remove the references to django-debug-toolvar from setup and settings, and put instructions into the developer docs as you suggest.

[Ed McDonagh]

Will do

[Ed McDonagh]

Adding docs and modifying settings and urls to remove django-debug-toolbar from default install. Refs #721

→ <<cset 17be9789dba6>>

[Ed McDonagh]

Removed django-debug-toolbar from setup.py Refs #721

→ <<cset 5d08680cde54>>

[Ed McDonagh]

Small mod and fix Refs #721

→ <<cset dcd34ebc50d4>>

[Ed McDonagh]

Docs at https://docs.openrem.org/en/issue721debugintolocal/code.html if anyone could take a look? @dplatten , @LuukO ?

We need to be wary that this doesn't break existing installs when settings.py drops the debug toolbar settings on upgrade. I think it will be ok.

[Ed McDonagh]

Adding ref #721 to changes

→ <<cset a451618b6df4>>

[Ed McDonagh]

Implementing @LuukO's proposal for concatonating tuples instead of copying them for ref #721. [skip ci] docs only

→ <<cset 8421c5fcda08>>

[Ed McDonagh]

Merged in issue721debugintolocal (pull request #283)

Fixes #721l

→ <<cset abf685b292c4>>