- edited description
Update charts to use new study level summary fields
Some are done already in issue #759 / Pull Request #315. Some, such as those using total DAP to be done afterwards.
Comments (10)
-
reporter -
Switched DX study- and request-level charts to use total_dap. References issue
#759and#768→ <<cset e78fe1731540>>
-
Switched RF study- and request-level charts to use total_dap from the study summary. Speed-up of a factor of 4 on my test system. References issue
#759and#768→ <<cset a3752bf10fe9>>
-
reporter Tests are passing fine, but uploading to coveralls is failing due to an issue they have: https://status.coveralls.io/?utm_source=embed
-
Altered chart calculation timing code so that it is logged when DEBUG is True and logs are DEBUG. References issue
#759and#768→ <<cset afc5890af9d2>>
-
reporter Merged in issue759AsManyTasks (pull request #315)
Fixes
#759Summary fields in GeneralStudyModuleAttr, Refs#768Update charts to use new study level summary fieldsApproved-by: David Platten
Thanks @dplatten and @LuukO for reviewing (and adding to!) I'm leaving the branch open as you are working in it David - not sure if you want to start a new branch to finish ref
#768off, from develop?→ <<cset 890828d285b3>>
-
reporter Merged in issue759AsManyTasks (pull request #315)
Fixes
#759Summary fields in GeneralStudyModuleAttr, Refs#768Update charts to use new study level summary fieldsApproved-by: David Platten
Thanks @dplatten and @LuukO for reviewing (and adding to!) I'm leaving the branch open as you are working in it David - not sure if you want to start a new branch to finish ref
#768off, from develop?→ <<cset 890828d285b3>>
-
I think that all the charts that can make use of the study level summary fields are now doing so. Are you happy for me to update the changes files in “develop” to reflect this?
-
reporter If the only files to change are the changes files, then yes. Close the issue with the commit.
-
- changed status to resolved
Updated changes files for issue
#768[skip ci]. Fixes issue#768→ <<cset 665cca7c18f3>>
- Log in to comment