Median chart values failing in python 3.7 Django 2.2 development version

[David Platten]

No description provided.

[David Platten]

Failure to calculate median chart values was not due to a problem with my database: an OpenREM 0.10 install on python 2.7 is able to calculate medians from exactly the same database that when used with a python 3.7-based Django 2.2 version of OpenREM results in failure. I have replaced the median calculation with a simpler solution from here: https://gist.github.com/rdmurphy/3f73c7b1826cacee34f6c2a855b12e2e. This does not require the special median migration in order to work, which is a bonus. References issue #788 and #789

→ <<cset 350e15417f8c>>

[Ed McDonagh]

Is it still restricted to postgresql, or will this method work with other databases?

[David Platten]

The author of the code (the github link in my first comment) describes this as “PostgreSQL specific Django Median aggregation function. So I think it’s still just for PostgreSQL users.

[Ed McDonagh]

HI @David Platten

I think we need to ‘cherry pick’ the 350e15417f8c changes and put them in a new branch to add to a PR and close this issue? Have I interpreted that correctly?

‌

[David Platten]

@Ed McDonagh agreed - I’ll create a new branch and put the appropriate changes in.

[Ed McDonagh]

Thanks

[David Platten]

Replaced median aggregation function with simpler code (from https://gist.github.com/rdmurphy/3f73c7b1826cacee34f6c2a855b12e2e). This is still PostgreSQL-specific, but no longer requires the special median migration to work. References issue #789

→ <<cset f386329ac76e>>

[David Platten]

Updated changes file [skip ci]. References issue #789

→ <<cset 98d988a5cc03>>

[David Platten]

Moved ABC import so that Ed's comment about sphinx autodocumentation still makes sense. References issue #789

→ <<cset d530115d35b0>>

[Ed McDonagh]

Ok. On a similar note, can you run the branch though black before creating the PR? (https://docs.openrem.org/en/latest/code_running_tests.html#code-formatting-and-tests)

Currently it changes all the skin map code because I had left that code previously, so please revert those changes after you have run black. I think the skin map changes will not make 1.0 now, so I will run it through black after all, in a different branch.

[Ed McDonagh]

Hmm. I haven’t dared to look at autodocumentation for a long time!

[David Platten]

Removed ABC use and import to see if Codacy is happy; code still works OK. References issue #789

→ <<cset afc37190793d>>

[David Platten]

Merged in issue789medianValuesFailingInDevVersion (pull request #388)

Issue789medianValuesFailingInDevVersion

Fixes issue #789

→ <<cset 1c305299b78f>>