Errors on "association release" and "move complete"
Issue #805
resolved
When running qrscu.py from the commandline with celery disabled i noticed the following two error messages in the console:
Traceback (most recent call last):
File "qrscu.py", line 1512, in <module>
qrscu_script()
File "qrscu.py", line 1489, in qrscu_script
get_empty_sr=processed_args['get_empty_sr']
File "qrscu.py", line 1090, in qrscu
movescu(str(query.query_id))
File "qrscu.py", line 1276, in movescu
assoc.release(0)
TypeError: release() takes 1 positional argument but 2 were given
and
Traceback (most recent call last):
File "qrscu.py", line 1512, in <module>
qrscu_script()
File "qrscu.py", line 1489, in qrscu_script
get_empty_sr=processed_args['get_empty_sr']
File "qrscu.py", line 1090, in qrscu
movescu(str(query.query_id))
File "qrscu.py", line 1295, in movescu
query.stage = msg
UnboundLocalError: local variable 'msg' referenced before assignment
Both can be easily solved (will commit them after posting this). Even though the celery task crashed on these errors, since the actual work was already done there’s no real harm done… but would there be a way of getting the tracktrace with celery enabled? Ideally we would like to see these errors in openrem_qr.log I suppose?
Comments (4)
-
reporter -
No functional change, just converting to f-strings and removing a blank line. Refs
#805→ <<cset 84d5188e6a87>>
-
- changed status to resolved
Merged in issue805assoc_move_errors (pull request #347)
Fix errors on "association release" and "move complete". Fixes
#805Approved-by: Ed McDonagh
→ <<cset 555872c02454>>
-
-
assigned issue to
-
assigned issue to
- Log in to comment
Fix errors on "association release" and "move complete". Refs
#805→ <<cset 31bff5c8f4c2>>