Specific Character Set with MultiValue content fails on import
get_values.safe_strings()
is not able to cope with a multi-value specific character set value. And it is marked as probably unnecessary - the decoding is now done in the .decode()
at the start.
Propose removing the function from the code.
Comments (14)
-
reporter -
reporter Added MultiValue SpecificCharacterString and PerformingPhysicianName with escape character, and test of import. Refs
#866. PersonName is copied from pydicom examples which are taken from David Clunie's examples.→ <<cset 2e88dd5ffba7>>
-
reporter Refactored patient_attribute_modules into extract_common, tidying up whilst working on ref
#866.→ <<cset f0c6884c0959>>
-
reporter Sorted out import order for extract_common whilst working on ref
#866.→ <<cset 09620d4a34f7>>
-
reporter Removed SpecificCharacterSet variables from dx. Moved imports to top. Refs
#866.→ <<cset 58ac915b9315>>
-
reporter Removed SpecificCharacterSet variables from ct_philips. Moved imports to top. Refs
#866.→ <<cset 3ecb5c4056d6>>
-
reporter Running black on ref
#866.→ <<cset dc9c1a4a53b2>>
-
reporter Requesting pylint not to complain about import order for modles imports. Refs
#866.→ <<cset eaf9029f7c0f>>
-
reporter Added ref
#866to changes.→ <<cset 6c69a7aaff87>>
-
reporter Removing redundant safe_strings function. Refs
#866→ <<cset 7e88e0848043>>
-
reporter Codacy - too many local variables. Refs
#866→ <<cset 1dfe059c6b61>>
-
reporter Codacy - switching imports around. Refs
#866→ <<cset 0263ba830fe0>>
-
reporter Codacy - might satisfy inconsistent-return-statements. Refs
#866→ <<cset cafde5183bcd>>
-
reporter - changed status to resolved
- Log in to comment
Removed the use of safe_strings and passing of the character set from rdsr. Refs
#866.→ <<cset 19c77808d67c>>