Address sonarcloud bugs

Issue #886 resolved

David Platten created an issue 2021-01-06

No description provided.

Comments (20)

David Platten reporter
Fixing bug (which did no harm) in skin dose map JavaScript. Refs issue ~~#886~~

→ <<cset 1353d3795110>>
- 2021-01-06T10:20:12+00:00
David Platten reporter
Adding captions to tables and scope to table headings in the detailed view templates [skip ci]. Refs issue ~~#886~~

→ <<cset ec765b7fcce9>>
- 2021-01-06T10:55:17+00:00
David Platten reporter
Hiding captions as their text is already in the section headings. Hopefully this still satisfies sonarcloud and screen readers [skip ci]. Refs issue ~~#886~~

→ <<cset ce61ddd7ad16>>
- 2021-01-06T11:10:03+00:00
David Platten reporter
@Ed McDonagh how do I make SonarCloud analyse the branch associated with this issue?
- 2021-01-06T11:25:44+00:00
Ed McDonagh
Hit the ‘Run' button on any standard pipeline. I have it as a step so that it only runs when we ask it to, to save minutes.
- 2021-01-06T11:29:01+00:00
David Platten reporter
Thanks. I just want to make sure that the changes I am making are resolving the bugs.
- 2021-01-06T11:32:13+00:00
Ed McDonagh
If Caption duplicates text, instead of hiding it you could use the aria thingy tags:

https://sonarcloud.io/organizations/openrem/rules?open=Web%3ATableWithoutCaptionCheck&rule_key=Web%3ATableWithoutCaptionCheck
- 2021-01-06T11:35:21+00:00
David Platten reporter
@Ed McDonagh I’m probably being thick. Do I click on the “run flake8”? There isn’t a button next to the sonarcloud scan or sonarcloud quality gate.
- 2021-01-06T11:41:47+00:00
David Platten reporter
I have the SonarCloud running now. I’ll use the aria tags instead of captions.
- 2021-01-06T11:45:23+00:00
Ed McDonagh
https://sonarcloud.io/dashboard?id=openrem_openrem&branch=issue886AddressSonarCloudBugs&resolved=false

‌
- 2021-01-06T11:45:47+00:00
David Platten reporter
Replaced table captions with aria-describedby. Avoids having to hide anything [skip ci]. Refs issue ~~#886~~

→ <<cset 5a4b66099387>>
- 2021-01-06T11:54:16+00:00
David Platten reporter
Added table aria-describedby and th scope in review_summary_list.html [skip ci]. Refs issue ~~#886~~

→ <<cset 2553a96ce796>>
- 2021-01-06T12:03:24+00:00
David Platten reporter
Added table aria-describedby and th scope in dicomsummary.html [skip ci]. Refs issue ~~#886~~

→ <<cset cc0770deae86>>
- 2021-01-06T12:09:49+00:00
David Platten reporter
Added table aria-describedby and th scope for more files [skip ci]. Refs issue ~~#886~~

→ <<cset b35ab82a11bd>>
- 2021-01-06T12:43:46+00:00
David Platten reporter
Replaced use of <row> with <tr>. Split some table headings onto separate lines [skip ci]. Refs issue ~~#886~~

→ <<cset cfdecce4b6cd>>
- 2021-01-06T12:53:43+00:00
David Platten reporter
Addressing the new SonarCloud issues [skip ci]. Refs issue ~~#886~~

→ <<cset a926db870b89>>
- 2021-01-06T15:14:41+00:00
David Platten reporter
Addressing SonarCloud issues for the remaining flies with at least 10 bugs [skip ci]. Refs issue ~~#886~~

→ <<cset 2d72c62abc59>>
- 2021-01-06T15:44:45+00:00
David Platten reporter
Correcting error where I used colspan instead of scope [skip ci]. Refs issue ~~#886~~

→ <<cset b9c9cbc8a776>>
- 2021-01-06T15:59:48+00:00
David Platten reporter
Updating changes file [skip ci]. Refs issue ~~#886~~

→ <<cset 010c84fbacbe>>
- 2021-01-06T16:20:02+00:00
Ed McDonagh
- changed status to resolved
Merged in issue886AddressSonarCloudBugs (pull request #440)

Fixes ~~#886~~

Approved-by: Ed McDonagh

Thanks David. I'll leave the translate flags for aria tags for now.

→ <<cset 5fd625ccab1f>>
- 2021-01-15T22:07:23+00:00
Log in to comment

Assignee: –

Type: task

Priority: major

Status: resolved

Component: –

Milestone: –

Votes: 0

Watchers: 1