Merged in issue528qrscucleanup (pull request #114)
6ea9ee1·Author: Ed McDonagh·Closed by: Ed McDonagh·2017-09-25
Description
Should only ever be one association open at a time now, with one association used for the query and a second for the move requests. Once this is merged in, I can address the requirement to get some level of CT images to enable @dplatten's Toshiba code to work.
Terminated initial association after echo instead of keeping it open. Better check of initial echo. More references to query_id in logging, but not completed. Refs 528
Fixing errors to test code introduced by changing signatures. Refs #528
Correcting some errors picked up by codacy. Refs #528, #526
Added study/series number to logging, completed doc strings, moved create AE to tools, general tidying, improved except, moved version of store to version. Refs 528 and needs testing
Added a check that the association is alive before sending each move request. It hasn't been triggered in my testing so far :-( Refs #528
Added assoc to _prune_series_response and fixed some of the test fakes etc. Refs #528
Moved tools import to after django setup to make testing easier. Moved _move_req to nearer movescu. Added max idle, not sure it does anything, can't see how to handle it. Refs #528
I don't think max idle works for a move association, so removing. Made Pending message more useful, reduced other messages to debug to reduce the noise. Refs #528
Should only ever be one association open at a time now, with one association used for the query and a second for the move requests. Once this is merged in, I can address the requirement to get some level of CT images to enable @dplatten's Toshiba code to work.
Terminated initial association after echo instead of keeping it open. Better check of initial echo. More references to query_id in logging, but not completed. Refs 528
Improved naming of RemoteAE. Refs #528
Fixing errors to test code introduced by changing signatures. Refs #528
Correcting some errors picked up by codacy. Refs #528, #526
Added study/series number to logging, completed doc strings, moved create AE to tools, general tidying, improved except, moved version of store to version. Refs 528 and needs testing
Removed some unused imports, refs #528.
Reduced the number of associations during the query to one. Query still works. Refs #528
Move only has one association now. Refs #528
Added a check that the association is alive before sending each move request. It hasn't been triggered in my testing so far :-( Refs #528
Added assoc to _prune_series_response and fixed some of the test fakes etc. Refs #528
Moved tools import to after django setup to make testing easier. Moved _move_req to nearer movescu. Added max idle, not sure it does anything, can't see how to handle it. Refs #528
I don't think max idle works for a move association, so removing. Made Pending message more useful, reduced other messages to debug to reduce the noise. Refs #528