Issue580 and Issue318 RF/DX and deleting studies

#149 Merged at 2eb3797
Repository
Branch
issue580rfanddx
Repository
Branch
develop
Author
  1. Ed McDonagh
Reviewers
Description

Refs #580, #318

  • Improves import routine of DX and RF studies
  • Adds 'dual' option in addition to DX and RF for user-defined modality
  • Sorts studies into DX or RF when set to dual
  • Adds option to re-process studies into RF and DX from the display names page
  • Adds link to review studies associated with any particular equipment name
  • Adds ability to delete all the studies associated with any particular equipment name
  • Adds ability to delete the entry in the equipment name table
  • Adds count of studies for each entry on the equipment table, with date of most recent
  • Display-name table page is now populated using AJAX for better responsiveness

I have pushed this to http://testing.openrem.org - go ahead and press the initial delete button as there is an 'are you sure' stage, but please don't delete as we'll have no studies left!

I'd appreciated it if you can try this branch out on copies of your production databases to see how it works.

Comments (12)

  1. Ed McDonagh

    Codacy Here is an overview of what got changed by this pull request:

    Issues
    ======
    - Added 3
    
    
    Clones added
    ============
    - openrem/remapp/views.py  2
    

    See the complete overview on Codacy

  2. David Platten

    @edmcdonagh, I've tried this out on a copy of my production database.

    I really like the review / delete feature: this is very useful to remove unwanted things from the database.

    I really like the AJAX population on the review page, and also the information on the number of studies / most recent date.

    I'm not so keen on the layout of the text and buttons on the review page, but that might just be me. I think I'd rather see the "Which should you choose..." line and "If you have added..." paragraph left-aligned, and then have the two buttons side-by-side underneath this. Perhaps these buttons should be red?

    I've not looked at the "dual" addition.

  3. Ed McDonagh author

    Hoorah, thanks for trying it out and feeding back :)

    With regards to the layout and wording, I agree. I got frustrated trying to achieve the two stage delete button without leaving the page. I achieved it, but by the time I had, the aesthetics were reduced to 'good enough'!

    The button is red on the second stage...

    I would be delighted if you wanted to make it look nicer. I've started on issue #114 now which has become a little urgent, so I can leave this PR open if you're willing to have a play?

  4. Luuk

    I had a quick look on testing.openrem.org: great work! A more close look will have to wait until next Tuesday. I agree the alignment of text for deleting studies can improve.

  5. Ed McDonagh author

    Codacy Here is an overview of what got changed by this pull request:

    Issues
    ======
    + Solved 25
    
    
    Coverage increased per file
    ===========================
    + openrem/remapp/extractors/rdsr.py  1
    
    
    Coverage decreased per file
    ===========================
    - openrem/remapp/views.py  -3
    - openrem/remapp/models.py  -1
    
    
    Clones added
    ============
    - openrem/remapp/views.py  2
    

    See the complete overview on Codacy

  6. Ed McDonagh author

    I'm happy to merge this in from my point of view. @dplatten - how about you? @LuukO - do you want us to wait till Tuesday so you can test it properly, or just deal with any issues if you find them as a new task?

  7. Ed McDonagh

    Codacy Here is an overview of what got changed by this pull request:

    Issues
    ======
    + Solved 2
    
    
    Clones added
    ============
    - openrem/remapp/views.py  2
    

    See the complete overview on Codacy